Skip to content

rte_ip_frag: various fixes for lib and examples

Anatoly Burakov dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ip_frag: rename RTE_IP_FRAG_ASSERT to IP_FRAG_ASSERTlib/librte_ip_frag/ip_frag_common.h lib/librte_ip_frag/rte_ipv4_fragmentation.c lib/librte_ip_frag/rte_ipv6_fragmentation.c+4 -40 replies
2/10ip_frag: fix debug macroslib/librte_ip_frag/rte_ipv4_reassembly.c+3 -30 replies
3/10ip_frag: renaming rte_ip_frag_pkt to ip_frag_pktlib/librte_ip_frag/ip_frag_common.h lib/librte_ip_frag/ip_frag_internal.c lib/librte_ip_frag/rte_ip_frag.h +2 more+29 -290 replies
4/10ip_frag: fix stats macro, rename rte_ip_frag_tbl_stat structureconfig/common_bsdapp config/common_linuxapp examples/ip_reassembly/main.c +1 more+6 -40 replies
5/10ip_frag: small fix, replace hardcode with a macrolib/librte_ip_frag/ip_frag_internal.c+1 -10 replies
6/10ip_frag: replace memmove with custom copyinglib/librte_ip_frag/rte_ipv6_reassembly.c+11 -10 replies
7/10ip_frag: fix order of arguments to key compare functionlib/librte_ip_frag/ip_frag_internal.c+3 -30 replies
8/10ip_fragmentation: small fixesexamples/ip_fragmentation/main.c+5 -10 replies
9/10ip_reassembly: small fixesexamples/ip_reassembly/main.c+8 -40 replies
10/10rte_ip_frag: API header file fixlib/librte_ip_frag/rte_ip_frag.h+2 -20 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchThomas Monjalon
SeriesA-b
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] rte_ip_frag: various fixes for lib and examples

This patchset fixes a few issues found during validation, and also does a bunch of renames (so that internally-used data structures aren't starting with rte_) and fixes a few typos.

Anatoly Burakov (10):
ip_frag: rename RTE_IP_FRAG_ASSERT to IP_FRAG_ASSERT
ip_frag: fix debug macros
ip_frag: renaming rte_ip_frag_pkt to ip_frag_pkt
ip_frag: fix stats macro, rename rte_ip_frag_tbl_stat structure
ip_frag: small fix, replace hardcode with a macro
ip_frag: replace memmove with custom copying
ip_frag: fix order of arguments to key compare function
ip_fragmentation: small fixes
ip_reassembly: small fixes
rte_ip_frag: API header file fix

 config/common_bsdapp                        |  1 +
 config/common_linuxapp                      |  1 +
 examples/ip_fragmentation/main.c            |  6 +++++-
 examples/ip_reassembly/main.c               | 16 ++++++++++------
 lib/librte_ip_frag/ip_frag_common.h         | 22 +++++++++++-----------
 lib/librte_ip_frag/ip_frag_internal.c       | 28 ++++++++++++++--------------
 lib/librte_ip_frag/rte_ip_frag.h            | 20 ++++++++++----------
 lib/librte_ip_frag/rte_ipv4_fragmentation.c |  2 +-
 lib/librte_ip_frag/rte_ipv4_reassembly.c    | 10 +++++-----
 lib/librte_ip_frag/rte_ipv6_fragmentation.c |  2 +-
 lib/librte_ip_frag/rte_ipv6_reassembly.c    | 16 +++++++++++++---
 11 files changed, 72 insertions(+), 52 deletions(-)
Signature · 1 line
1.8.1.4