Skip to content

sched: static_key sched_feat race + cleanup

Jason Baron lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2sched: remove extra static_key function indirectionkernel/sched/sched.h+1 -110 replies
2/2sched: fix static_key race with sched_featkernel/sched/core.c+5 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] sched: static_key sched_feat race + cleanup

Hi,

Andi Kleen previously pointed out a get/set race in the sched_feat() infrastructure. I had previously proposed to address this with a new static_key set_true/set_false API:

http://www.gossamer-threads.com/lists/linux/kernel/1955879

However, I think its simpler to just add higher level locking as Ingo previously suggested, and that is how other consumers of the this interface are already operating. It seems a bit like overkill to add this new API, just for this one case.

So, this locking change is in patch 2. Patch 1 is a small cleanup, but no functional change.

Thanks,

-Jason

Jason Baron (2):
sched: remove extra static_key function indirection
sched: fix static_key race with sched_feat

 kernel/sched/core.c  |  5 +++++
 kernel/sched/sched.h | 12 +-----------
 2 files changed, 6 insertions(+), 11 deletions(-)
Signature · 1 line
1.8.2.rc2