Skip to content

RFC hrtimer: drop active hrtimer checks after adding it

Viresh Kumar lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7hrtimer: Warn if hrtimer_start*() failed to enqueue hrtimerkernel/hrtimer.c+2 -02 replies
2/7hrtimer: don't check for active hrtimer after adding itkernel/hrtimer.c+0 -42 replies
3/7tick: don't check for active hrtimer after adding itkernel/time/tick-sched.c+18 -270 replies
4/7sched: don't check for active hrtimer after adding itkernel/sched/core.c kernel/sched/deadline.c+10 -120 replies
5/7futex: don't check for active hrtimer after adding itkernel/futex.c+1 -40 replies
6/7rtmutex: don't check for active hrtimer after adding itkernel/locking/rtmutex.c+1 -40 replies
7/7net: don't check for active hrtimer after adding itnet/core/pktgen.c+0 -24 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/7] hrtimer: drop active hrtimer checks after adding it

hrtimer_start*() family never fails to enqueue a hrtimer to a clock-base. The only special case is when the hrtimer was in past. If it is getting enqueued to local CPUs's clock-base, we raise a softirq and exit, else we handle that on next interrupt on remote CPU.

At several places in the kernel, we try to make sure if hrtimer was added properly or not by calling hrtimer_active(), like:

	hrtimer_start(timer, expires, mode);
	if (hrtimer_active(timer)) {
		/* Added successfully */
	} else {
		/* Was added in the past */
	}

As hrtimer_start*() never fails, hrtimer_active() is guaranteed to return '1'. So, there is no point calling hrtimer_active().

First patch adds a WARN_ON_ONCE() to __hrtimer_start_range_ns() to make sure hrtimers are always enqueued from it. Next 6 patches update several parts of kernel to drop calls to hrtimer_active() after starting a hrtimer.

Rebased over 3.16-rc4 and pushed here:
git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/linux.git hrtimer/drop-hrtimer-active-calls

Cc Darren Hart <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Peter Zijlstra <[email protected]>

Viresh Kumar (7):
hrtimer: Warn if hrtimer_start*() failed to enqueue hrtimer
hrtimer: don't check for active hrtimer after adding it
tick: don't check for active hrtimer after adding it
sched: don't check for active hrtimer after adding it
futex: don't check for active hrtimer after adding it
rtmutex: don't check for active hrtimer after adding it
net: don't check for active hrtimer after adding it

 kernel/futex.c           |  5 +----
 kernel/hrtimer.c         |  6 ++----
 kernel/locking/rtmutex.c |  5 +----
 kernel/sched/core.c      | 20 +++++++++-----------
 kernel/sched/deadline.c  |  2 +-
 kernel/time/tick-sched.c | 45 ++++++++++++++++++---------------------------
 net/core/pktgen.c        |  2 --
 7 files changed, 32 insertions(+), 53 deletions(-)
Signature · 1 line
2.0.0.rc2