Skip to content

RFC Remove enforced --foreign in autoreconf

Ross Burton openembedded-core openembedded-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7bzip2: use "foreign" automake strictnessmeta/recipes-extended/bzip2/bzip2-1.0.6/configure.ac+1 -10 replies
2/7libid3tag: use "foreign" automake strictnessmeta/recipes-multimedia/libid3tag/libid3tag/obsolete_automake_macros.patch+2 -10 replies
3/7which: use "foreign" automake strictnessmeta/recipes-extended/which/which-2.20/automake.patch meta/recipes-extended/which/which_2.20.bb+11 -00 replies
4/7libmad: use "foreign" automake strictnessmeta/recipes-multimedia/libmad/libmad/automake-foreign.patch meta/recipes-multimedia/libmad/libmad_0.15.1b.bb+13 -00 replies
5/7oprofile: use "foreign" automake strictnessmeta/recipes-kernel/oprofile/oprofile.inc meta/recipes-kernel/oprofile/oprofile/automake-foreign.patch+8 -00 replies
6/7ltp: use "foreign" automake strictnessmeta/recipes-extended/ltp/ltp/automake-foreign.patch meta/recipes-extended/ltp/ltp_20140422.bb+21 -00 replies
7/7autoconf: remove automake patch enforcing --foreignmeta/recipes-devtools/autoconf/autoconf/autoreconf-foreign.patch meta/recipes-devtools/autoconf/autoconf_2.69.bb+0 -143 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7][RFC] Remove enforced --foreign in autoreconf

Hi,

Since 2004 we've been forcibly passing --foreign to automake in autoreconf. This is a change from upstream behaviour and can actually break packages that expect GNU behaviour (admittedly the failure case reported was "interesting"), and I'm on a bit of a mission to remove patches that don't have a solid reason behind them.

Forcing --foreign doesn't seem that important these days as the majority of packages are telling automake they're foreign, There are a few packages that need patches for this change, notably they're mostly packages that haven't seen a release for ten years.

This series is build tested against a world build in oe-core for NUC, so I'd call it a demonstration that the patch is viable and would appreciate others running build tests against other machines or layers.

Ross

The following changes since commit 9e99bcffec594cb5b4c3533200e8eb56d32e6a77:

insane: Ensure do_package_qa happens after do_packagedata (2014-07-11 23:20:04 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib ross/automake

for you to fetch changes up to 406153008dc78f4e3198c012f2db98fcac09b5c1:

  autoconf: remove automake patch enforcing --foreign (2014-07-15 17:05:29 +0100)

----------------------------------------------------------------
Ross Burton (7):
bzip2: use "foreign" automake strictness
libid3tag: use "foreign" automake strictness
which: use "foreign" automake strictness
libmad: use "foreign" automake strictness
oprofile: use "foreign" automake strictness
ltp: use "foreign" automake strictness
autoconf: remove automake patch enforcing --foreign

 .../autoconf/autoconf/autoreconf-foreign.patch     |   13 -------------
 meta/recipes-devtools/autoconf/autoconf_2.69.bb    |    1 -
 .../bzip2/bzip2-1.0.6/configure.ac                 |    2 +-
 .../ltp/ltp/automake-foreign.patch                 |   20 ++++++++++++++++++++
 meta/recipes-extended/ltp/ltp_20140422.bb          |    1 +
 .../which/which-2.20/automake.patch                |   10 ++++++++++
 meta/recipes-extended/which/which_2.20.bb          |    1 +
 meta/recipes-kernel/oprofile/oprofile.inc          |    1 +
 .../oprofile/oprofile/automake-foreign.patch       |    7 +++++++
 .../libid3tag/obsolete_automake_macros.patch       |    3 ++-
 .../libmad/libmad/automake-foreign.patch           |   12 ++++++++++++
 meta/recipes-multimedia/libmad/libmad_0.15.1b.bb   |    1 +
 12 files changed, 56 insertions(+), 16 deletions(-)
 delete mode 100644 meta/recipes-devtools/autoconf/autoconf/autoreconf-foreign.patch
 create mode 100644 meta/recipes-extended/ltp/ltp/automake-foreign.patch
 create mode 100644 meta/recipes-extended/which/which-2.20/automake.patch
 create mode 100644 meta/recipes-kernel/oprofile/oprofile/automake-foreign.patch
 create mode 100644 meta/recipes-multimedia/libmad/libmad/automake-foreign.patch

Ross Burton (7):
bzip2: use "foreign" automake strictness
libid3tag: use "foreign" automake strictness
which: use "foreign" automake strictness
libmad: use "foreign" automake strictness
oprofile: use "foreign" automake strictness
ltp: use "foreign" automake strictness
autoconf: remove automake patch enforcing --foreign

 .../autoconf/autoconf/autoreconf-foreign.patch     |   13 -------------
 meta/recipes-devtools/autoconf/autoconf_2.69.bb    |    1 -
 .../bzip2/bzip2-1.0.6/configure.ac                 |    2 +-
 .../ltp/ltp/automake-foreign.patch                 |   20 ++++++++++++++++++++
 meta/recipes-extended/ltp/ltp_20140422.bb          |    1 +
 .../which/which-2.20/automake.patch                |   10 ++++++++++
 meta/recipes-extended/which/which_2.20.bb          |    1 +
 meta/recipes-kernel/oprofile/oprofile.inc          |    1 +
 .../oprofile/oprofile/automake-foreign.patch       |    7 +++++++
 .../libid3tag/obsolete_automake_macros.patch       |    3 ++-
 .../libmad/libmad/automake-foreign.patch           |   12 ++++++++++++
 meta/recipes-multimedia/libmad/libmad_0.15.1b.bb   |    1 +
 12 files changed, 56 insertions(+), 16 deletions(-)
 delete mode 100644 meta/recipes-devtools/autoconf/autoconf/autoreconf-foreign.patch
 create mode 100644 meta/recipes-extended/ltp/ltp/automake-foreign.patch
 create mode 100644 meta/recipes-extended/which/which-2.20/automake.patch
 create mode 100644 meta/recipes-kernel/oprofile/oprofile/automake-foreign.patch
 create mode 100644 meta/recipes-multimedia/libmad/libmad/automake-foreign.patch
Signature · 1 line
1.7.10.4