random,x86,kvm: Rework arch RNG seeds and get some from kvm
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest7 patches 2 repliesIn review
- v55 patches 19 repliesSuperseded
- v45 patches 8 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 5 patches | 16 replies | Superseded | |
| v2 | 5 patches | 2 replies | Superseded | |
| v1 | 4 patches | 15 replies | Superseded |
Changes in v6 from the cover letter
- Moved the generic changes to the beginning.
- Renamed arch_get_rng_seed to arch_rng_init.
- The timekeeping change is new.
- random.c registers a syscore callback to reseed on resume.
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | random: Add and use arch_rng_initdrivers/ include/ | +51 | 0 replies | |
| 2/7 | random, timekeeping: Collect timekeeping entropy in the timekeeping codedrivers/ kernel/ | +11 | 2 replies | |
| 3/7 | random: Reseed pools on resumedrivers/ | +23 | 0 replies | |
| 4/7 | x86,kvm: Add MSR_KVM_GET_RNG_SEED and a matching feature bitDocumentation/ arch/ arch/ +1 more | +11 | 0 replies | |
| 5/7 | x86,random: Add an x86 implementation of arch_rng_initarch/ arch/ arch/ | +59 | 0 replies | |
| 6/7 | x86,random,kvm: Use KVM_GET_RNG_SEED in arch_get_rng_seedarch/ arch/ arch/ +1 more | +47 | 0 replies | |
| 6/7 | x86,random,kvm: Use KVM_GET_RNG_SEED in arch_rng_initarch/ arch/ arch/ +1 more | +47 | 0 replies | |
| 7/7 | x86,kaslr: Use MSR_KVM_GET_RNG_SEED for KASLR if availablearch/ arch/ | +45 | 0 replies |
Reviews trailers per patch
5 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Theodore Ts'o | Paolo Bonzini | Kees Cook |
|---|---|---|---|
| 1/7 | A-b | ||
| 2/7 | |||
| 3/7 | |||
| 4/7 | A-b | ||
| 5/7 | |||
| 6/7 | A-b A-b | ||
| 6/7 | A-b A-b | ||
| 7/7 | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v6 0/7] random,x86,kvm: Rework arch RNG seeds and get some from kvm
This introduces and uses a very simple synchronous mechanism to get /dev/urandom-style bits appropriate for initial KVM PV guest RNG seeding.
It also re-works the way that architectural random data is fed into random.c's pools. Timekeeping randomness now comes directly from the timekeeping core rather than being pulled in from init_std_data, and timekeeping randomness is added both on boot and on resume. I added a new arch hook called arch_rng_init. The default implementation is more or less the same as the current code, except that random_get_entropy is now called unconditionally. We now also call init_std_data on resume.
x86 gets a custom arch_rng_init. It will use KVM_GET_RNG_SEED if available, and, if it does anything, it will log the number of bits collected from each available architectural source. If more paravirt seed sources show up, it will be a natural place to add them.
I sent the corresponding kvm-unit-tests and qemu changes separately.
Changes from v5:
- Moved the generic changes to the beginning.
- Renamed arch_get_rng_seed to arch_rng_init.
- The timekeeping change is new.
- random.c registers a syscore callback to reseed on resume.
Changes from v4:
- Got rid of the RDRAND behavior change. If this series is accepted, I may resend it separately, but I think it's an unrelated issue.
- Fix up the changelog entries -- I misunderstood how the old code worked.
- Avoid lots of failed attempts to use KVM_GET_RNG_SEED if it's not available.
Changes from v3:
- Other than KASLR, the guest pieces are completely rewritten. Patches 2-4 have essentially nothing in common with v2.
Changes from v2:
- Bisection fix (patch 2 had a misplaced brace). The final states is identical to that of v2.
- Improve the 0/5 description a little bit.
Changes from v1:
- Split patches 2 and 3
- Log all arch sources in init_std_data
- Fix the 32-bit kaslr build
Andy Lutomirski (7):
random: Add and use arch_rng_init
random, timekeeping: Collect timekeeping entropy in the timekeeping
code
random: Reseed pools on resume
x86,kvm: Add MSR_KVM_GET_RNG_SEED and a matching feature bit x86,random: Add an x86 implementation of arch_rng_init x86,random,kvm: Use KVM_GET_RNG_SEED in arch_rng_init x86,kaslr: Use MSR_KVM_GET_RNG_SEED for KASLR if available
Documentation/virtual/kvm/cpuid.txt | 3 ++ arch/x86/Kconfig | 4 ++ arch/x86/boot/compressed/aslr.c | 27 +++++++++++++ arch/x86/include/asm/archrandom.h | 6 +++ arch/x86/include/asm/kvm_guest.h | 9 +++++ arch/x86/include/asm/processor.h | 21 ++++++++-- arch/x86/include/uapi/asm/kvm_para.h | 2 + arch/x86/kernel/Makefile | 2 + arch/x86/kernel/archrandom.c | 74 ++++++++++++++++++++++++++++++++++++ arch/x86/kernel/kvm.c | 10 +++++ arch/x86/kvm/cpuid.c | 3 +- arch/x86/kvm/x86.c | 4 ++ drivers/char/random.c | 42 ++++++++++++++++---- include/linux/random.h | 40 +++++++++++++++++++ kernel/time/timekeeping.c | 11 ++++++ 15 files changed, 246 insertions(+), 12 deletions(-) create mode 100644 arch/x86/kernel/archrandom.c
Signature · 1 line
1.9.3