Skip to content

Allow VPC and VDI to be created over protocols

Jeff Cody qemu-devel 3 versions – Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 1 replyApplied
  2. v25 patches 5 repliesSuperseded
  3. v14 patches 6 repliesSuperseded

Changes in v3 from the cover letter

* Patch 2: Removed extra #ifdef __linux__ from top of file (Max)
* Patch 4: Removed extra #ifdef __linux__ from top of file (Max)
* Patch 5: Removed output from debug cruft (Max)
* Added Max's R-b to remaining patches

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5block: allow bdrv_unref() to be passed NULL pointersblock.c+3 -00 replies
2/5block: vdi - use block layer ops in vdi_create, instead of posix callsblock/vdi.c+29 -460 replies
3/5block: use the standard 'ret' instead of 'result'block/vdi.c+18 -180 replies
4/5block: vpc - use block layer ops in vpc_create, instead of posix callsblock/vpc.c+43 -630 replies
5/5block: iotest - update 084 to test static VDI image creationtests/qemu-iotests/084 tests/qemu-iotests/084.out+28 -20 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMax Reitz
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/5] Allow VPC and VDI to be created over protocols

Changes from v2 -> v3:
* Patch 2: Removed extra #ifdef __linux__ from top of file (Max)
* Patch 4: Removed extra #ifdef __linux__ from top of file (Max)
* Patch 5: Removed output from debug cruft (Max)
* Added Max's R-b to remaining patches

Changes from v1 -> v2:
* Patch 2: Use'bs' instead of 'bs->file' (Max)
* Patch 3: Same as patch 2 (ripple through)
* Patch 5: Update VDI test for static image (Kevin)
* Added Max's R-b to patches 1,3,4

This allows VPC and VDI to be created over protocols; currently, they use posix calls directly to open, seek, and write into new image files. This obviously precludes them from being able to be created over a protocol, like glusterfs.

Jeff Cody (5):
block: allow bdrv_unref() to be passed NULL pointers
block: vdi - use block layer ops in vdi_create, instead of posix calls
block: use the standard 'ret' instead of 'result'
block: vpc - use block layer ops in vpc_create, instead of posix calls
block: iotest - update 084 to test static VDI image creation

 block.c                    |   3 ++
 block/vdi.c                |  89 +++++++++++++++----------------------
 block/vpc.c                | 106 ++++++++++++++++++---------------------------
 tests/qemu-iotests/084     |  16 ++++++-
 tests/qemu-iotests/084.out |  14 ++++++
 5 files changed, 110 insertions(+), 118 deletions(-)
Signature · 1 line
1.9.3