fs.h/dlm: Neatening and argument removals
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 12 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | fs.h: Remove unnecessary extern prototypesinclude/ | +318 | 1 reply | |
| 2/9 | fs.h: Whitespace neateninginclude/ | +250 | 1 reply | |
| 3/9 | fs.h: A few more whitespace neateningsinclude/ | +102 | 1 reply | |
| 4/9 | fs.h: Add argument names to struct file_lock_operations (*funcs)include/ | +2 | 1 reply | |
| 5/9 | fs.h: Add member argument descriptions to lock_manager_operationsinclude/ | +6 | 1 reply | |
| 6/9 | dlm: plock: Add argument descriptions to notifyfs/ | +2 | 0 replies | |
| 7/9 | dlm: fs: Remove unused conf from lm_grantfs/ fs/ include/ | +8 | 1 reply | |
| 8/9 | dlm: plock: Reduce indentation by rearranging orderfs/ | +13 | 1 reply | |
| 9/9 | fs: dlm: lockd: Convert int result to unsigned char typefs/ fs/ include/ | +9 | 5 replies |
Reviews trailers per patch
4 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Jeff Layton |
|---|---|
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | A-b |
| 5/9 | A-b |
| 6/9 | |
| 7/9 | R-b |
| 8/9 | R-b |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] fs.h/dlm: Neatening and argument removals
fs.h is an important file read by many.
Because of its age and the number of people that have modified it, it's not particularly kernel coding style conformant.
Make it more so.
dlm has an unnecessary always NULL argument passed around. Remove it along with some other neatenings while adding function prototype argument descriptions.
Joe Perches (9):
fs.h: Remove unnecessary extern prototypes
fs.h: Whitespace neatening
fs.h: A few more whitespace neatenings
fs.h: Add argument names to struct file_lock_operations (*funcs) fs.h: Add member argument descriptions to lock_manager_operations
dlm: plock: Add argument descriptions to notiy
dlm: fs: Remove unused conf from lm_grant
dlm: plock: Reduce indentation by rearranging order
fs: dlm: lockd: Convert int result to unsigned char type
fs/dlm/plock.c | 34 +- fs/lockd/svclock.c | 16 +- include/linux/fs.h | 1201 ++++++++++++++++++++++++++-------------------------- 3 files changed, 627 insertions(+), 624 deletions(-)
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty