Skip to content

virtio-rng: contribute to early randomness requests

Amit Shah lkml virtualization 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 8 repliesIn review
  2. v13 patches 1 replySuperseded

Changes in v2 from the cover letter

- update patch 3 to store the hwrng_register_done bool per-device rather than global
- add patch 2 that re-arranges struct elems for better packing.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4virtio: rng: remove unused struct elementdrivers/char/hw_random/virtio-rng.c+0 -10 replies
2/4virtio: rng: re-arrange struct elements for better packingdrivers/char/hw_random/virtio-rng.c+2 -20 replies
3/4virtio: rng: delay hwrng_register() till driver is readydrivers/char/hw_random/virtio-rng.c+15 -106 replies
4/4Revert "hwrng: virtio - ensure reads happen after successful probe"drivers/char/hw_random/core.c drivers/char/hw_random/virtio-rng.c+0 -150 replies
4/4Revert "hwrng: virtio - ensure reads happen after successful probe"drivers/char/hw_random/core.c drivers/char/hw_random/virtio-rng.c+0 -150 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJason Cooper
SeriesR-b
1/4
2/4
3/4
4/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] virtio-rng: contribute to early randomness requests

v2:
- update patch 3 to store the hwrng_register_done bool per-device rather than global
- add patch 2 that re-arranges struct elems for better packing.

Hi,

This series enables virtio-rng to service the early randomness requests made by the hwrng core (patch 3), with Herbert's idea of using the scan routine.

Patch 4 reverts the previous restriction, which no longer applies, to not send read requests to the host before successful probe.

Patches 1 and 2 are minor cleanups.

Please review and apply,

Amit Shah (4):
virtio: rng: remove unused struct element
virtio: rng: re-arrange struct elements for better packing
virtio: rng: delay hwrng_register() till driver is ready Revert "hwrng: virtio - ensure reads happen after successful probe"

 drivers/char/hw_random/core.c       |  6 ------
 drivers/char/hw_random/virtio-rng.c | 39 ++++++++++++++++---------------------
 2 files changed, 17 insertions(+), 28 deletions(-)
Signature · 1 line
1.9.3

Read the cover letter in its thread