Skip to content

GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs

Peter Crosthwaite qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 7 repliesIn review
  2. v214 patches 6 repliesSuperseded
  3. v116 patches 16 repliesSuperseded

Changes in v3 from the cover letter

Remove num_irq from sysbus (P14)
Removed out of tree deps.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14qdev: gpio: Don't allow name share between I and Ohw/core/qdev.c+2 -00 replies
2/14qdev: gpio: Register GPIO inputs as child objectshw/core/qdev.c+9 -00 replies
3/14qdev: gpio: Register GPIO outputs as QOM linkshw/core/qdev.c+12 -00 replies
4/14qmp: qstring: Handle NULL stringsqobject/qstring.c+7 -52 replies
5/14qom: Allow clearing of a Link propertyqom/object.c+2 -22 replies
6/14qom: Demote already-has-a-parent to a regular errorqom/object.c+5 -10 replies
7/14qdev: gpio: Re-impement qdev_connect_gpio QOM stylehw/core/qdev.c+8 -41 reply
8/14qdev: gpio: Add API for intercepting a GPIOhw/core/qdev.c include/hw/qdev-core.h+27 -00 replies
9/14qtest/irq: Rework IRQ interceptionhw/core/irq.c qtest.c+12 -50 replies
10/14irq: Remove qemu_irq_intercept_outhw/core/irq.c include/hw/irq.h+0 -70 replies
11/14qdev: gpio: delete NamedGPIOList::outhw/core/qdev.c include/hw/qdev-core.h+0 -20 replies
12/14qdev: gpio: Remove qdev_init_gpio_out x1 restrictionhw/core/qdev.c+1 -20 replies
13/14qdev: gpio: Define qdev_pass_gpios()hw/core/qdev.c include/hw/qdev-core.h+29 -00 replies
14/14sysbus: Use TYPE_DEVICE GPIO functionalityhw/core/sysbus.c include/hw/sysbus.h+6 -210 replies

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlexander GrafPaolo Bonzini
SeriesR-b
1/14R-b
2/14R-b
3/14R-b
4/14R-b
5/14R-b
6/14R-b
7/14R-b
8/14R-b
9/14R-b
10/14R-b
11/14R-b
12/14R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH qom v3 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs

Hi All,

So phase one was the QOMification of qemu_irq. This is the next step. We start to setup GPIOs as proper QOM objects. Inputs are child objects of their device. Outputs are settable Links and connection is made via proper setting of a QOM link.

We then cleanup Sysbus to simply re-use device level GPIOs and get rid of it's special IRQ handling code.

CHanged since v2:
Remove num_irq from sysbus (P14)
Removed out of tree deps.
Changed since v1:
Addressed Alex review
Dropped IRQ g_new0 changes

Peter Crosthwaite (14):
qdev: gpio: Don't allow name share between I and O
qdev: gpio: Register GPIO inputs as child objects
qdev: gpio: Register GPIO outputs as QOM links
qmp: qstring: Handle NULL strings
qom: Allow clearing of a Link property
qom: Demote already-has-a-parent to a regular error
qdev: gpio: Re-impement qdev_connect_gpio QOM style
qdev: gpio: Add API for intercepting a GPIO qtest/irq: Rework IRQ interception
irq: Remove qemu_irq_intercept_out
qdev: gpio: delete NamedGPIOList::out
qdev: gpio: Remove qdev_init_gpio_out x1 restriction
qdev: gpio: Define qdev_pass_gpios()
sysbus: Use TYPE_DEVICE GPIO functionality

 hw/core/irq.c          |  8 +----
 hw/core/qdev.c         | 90 ++++++++++++++++++++++++++++++++++++++++++++++----
 hw/core/sysbus.c       | 20 ++---------
 include/hw/irq.h       |  1 -
 include/hw/qdev-core.h |  6 +++-
 include/hw/sysbus.h    |  7 ++--
 qobject/qstring.c      | 12 ++++---
 qom/object.c           | 10 ++++--
 qtest.c                | 15 ++++++---
 9 files changed, 120 insertions(+), 49 deletions(-)
Signature · 1 line
2.1.0.1.g27b9230