module: add support for unsafe, tainting parameters
Status from this message: Applied.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | module: rename KERNEL_PARAM_FL_NOARG to avoid confusioninclude/ kernel/ kernel/ +1 more | +7 | 0 replies | |
| 2/4 | module: make it possible to have unsafe, tainting module paramsdrivers/ include/ kernel/ | +47 | 0 replies | |
| 3/4 | module: add module_param_unsafe and module_param_named_unsafeinclude/ | +18 | 0 replies | |
| 4/4 | drm/i915: taint the kernel if unsafe module parameters are setdrivers/ | +4 | 0 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by.
| Patch | Daniel Vetter | Jani Nikula |
|---|---|---|
| Series | Based-on-patches-by | Based-on-patches-by |
| 1/4 | ||
| 2/4 | ||
| 3/4 | ||
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] module: add support for unsafe, tainting parameters
This is a generic version of Daniel's patch [1] letting us have unsafe module parameters (experimental, debugging, testing, etc.) that taint the kernel when set. Quoting Daniel,
"""
Users just love to set random piles of options since surely enabling all the experimental stuff helps. Later on we get bug reports because it all fell apart.
Even more fun when it's labelled a regression when some change only just made the feature possible (e.g. stolen memory fixes suddenly making fbc possible).
Make it clear that users are playing with fire here. """
Patches 1-3 add the core functionality, patch 4 is our use case as an example.
BR,
Jani.
[1] http://lkml.kernel.org/r/[email protected]
Jani Nikula (4):
module: rename KERNEL_PARAM_FL_NOARG to avoid confusion
module: make it possible to have unsafe, tainting module params
module: add module_param_unsafe and module_param_named_unsafe drm/i915: taint the kernel if unsafe module parameters are set
drivers/gpu/drm/i915/i915_params.c | 8 ++--- drivers/tty/serial/8250/8250_core.c | 2 +- include/linux/moduleparam.h | 64 +++++++++++++++++++++++++++++++------ kernel/module.c | 2 +- kernel/params.c | 17 ++++++++-- security/apparmor/lsm.c | 4 +-- 6 files changed, 76 insertions(+), 21 deletions(-)
Signature · 1 line
1.9.1