Skip to content

drm/i915: backlight sysfs bl_power and brightness == 0

Jani Nikula intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915/dp: split up panel power control from backlight pwm controldrivers/gpu/drm/i915/intel_dp.c+26 -132 replies
2/4drm/i915: add some framework for backlight bl_power supportdrivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_panel.c+28 -02 replies
3/4drm/i915/dp: make backlight bl_power control power sequencer backlightdrivers/gpu/drm/i915/intel_dp.c+22 -03 replies
4/4drm/i915: switch off backlight for backlight class 0 brightnessdrivers/gpu/drm/i915/intel_panel.c+2 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] drm/i915: backlight sysfs bl_power and brightness == 0

This series adds support for backlight class sysfs bl_power attribute for eDP panels, which allows switching the backlight on/off. This is done using the eDP panel power control as a sub-state of everything else being enabled. Patch 4 also makes 0 brightness switch off the eDP backlight using the same mechanism. This is all eDP specific, with no support for LVDS.

I'm not particularly fond of these patches, but there appears to be demand for them, particularly since

commit 6dda730e55f412a6dfb181cae6784822ba463847

Author: Jani Nikula <[email protected]>
Date:   Tue Jun 24 18:27:40 2014 +0300

drm/i915: respect the VBT minimum backlight brightness

All the discussions seem to just drag on and on without code to speak about, so here goes. I've tried to make this as simple and unintrusive as possible.

BR,
Jani.

Jani Nikula (4):
drm/i915/dp: split up panel power control from backlight pwm control drm/i915: add some framework for backlight bl_power support drm/i915/dp: make backlight bl_power control power sequencer backlight drm/i915: switch off backlight for backlight class 0 brightness

 drivers/gpu/drm/i915/intel_dp.c    | 61 ++++++++++++++++++++++++++++++--------
 drivers/gpu/drm/i915/intel_drv.h   |  2 ++
 drivers/gpu/drm/i915/intel_panel.c | 27 +++++++++++++++++
 3 files changed, 77 insertions(+), 13 deletions(-)
Signature · 1 line
1.9.1