Skip to content

sb_edac: i2c_imc staging submission prep

Andy Lutomirski linux-pci lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Move Intel SNB device ids from sb_edac to pci_ids.hdrivers/edac/sb_edac.c include/linux/pci_ids.h+15 -303 replies
2/2sb_edac: Claim a different PCI devicedrivers/edac/sb_edac.c+1 -14 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchBjorn HelgaasAristeu Rozanski
1/2A-b A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] sb_edac: i2c_imc staging submission prep

I'd like to submit my i2c_imc driver to -staging, but the sb_edac driver is currently squatting on my pci id :) sb_edac is a strange
beast: it uses registers from several PCI devcies, but the one that it registers with the driver core is the SMBUS controller.

This trivial series moves sb_edac's PCI ids to pci_ids.h (they're not exclusive to the EDAC hardware) and changes the PCI ID that is used to detect the EDAC hardware.

I think that i2c_imc is a good staging candidate: the driver is IMO quite clean, the hardware is very common, and I know of some users (unrelated to me!) that use it for development, but it's not yet acceptable as a real driver. In particular, it needs confirmation from Intel as to whether it handshakes correctly with BIOS. In the mean time, it's perfectly safe to use *if you know that your system isn't doing something special with its DIMM SMBUS registers*.

I have reason to believe that I may be able to get a information or a review from the right people at Intel in a couple of months, and I suspect that some people in the NV-DIMM community would be interested in this stuff.

I realize that the timing is a bit awkward here. These patches have been floating around for almost a year. I'd be okay with them going in for 3.17 or 3.18. If I understand correctly, the deadline for staging drivers is much later than the merge window, but I don't want to submit the i2c_imc driver itself to staging until these prep patches are in.

Andy Lutomirski (2):
Move Intel SNB device ids from sb_edac to pci_ids.h
sb_edac: Claim a different PCI device

 drivers/edac/sb_edac.c  | 32 +-------------------------------
 include/linux/pci_ids.h | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 31 deletions(-)
Signature · 1 line
1.9.3