Skip to content

udev-cache related changes

Richard Tollerton openembedded-core 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest12 patches 2 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12udev-cache: Update cache tarball atomicallymeta/recipes-core/udev/udev/udev-cache+3 -10 replies
2/12udev-cache: Compress the cachemeta/recipes-core/udev/udev/udev-cache meta/recipes-core/udev/udev/udev-cache.default+3 -20 replies
3/12udev-cache: choose a more descriptive cache filenamemeta/recipes-core/udev/udev/udev-cache.default+1 -10 replies
4/12busybox: enable `tar -m`meta/recipes-core/busybox/busybox/defconfig+1 -10 replies
5/12udev-cache: strip timestamps on extractmeta/recipes-core/udev/udev/init+1 -10 replies
6/12udev-cache: omit sockets and filesystems mounted under /devmeta/recipes-core/udev/udev/udev-cache+2 -10 replies
7/12udev-cache: Don't ignore error messages from cache extractmeta/recipes-core/udev/udev/init+1 -10 replies
8/12udev-cache: parametrize sysconf file pathsmeta/recipes-core/udev/udev/init meta/recipes-core/udev/udev/udev-cache+10 -60 replies
9/12udev-cache: get system config immediately before cachemeta/recipes-core/udev/udev/init meta/recipes-core/udev/udev/udev-cache+31 -302 replies
10/12udev-cache: invalidate on rules.d changesmeta/recipes-core/udev/udev/init meta/recipes-core/udev/udev/udev-cache+10 -00 replies
11/12udev-cache: Update cache asynchronouslymeta/recipes-core/udev/udev/udev-cache+11 -80 replies
12/12udev-cache: refactor; improve verbosity and error handlingmeta/recipes-core/udev/udev/udev-cache+20 -130 replies

Reviews trailers per patch

3 of 12 patches have a Reviewed-by or Acked-by.

PatchGratian CrisanOtavio Salvador
1/12A-b
2/12
3/12A-b A-b
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12A-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/12] udev-cache related changes

This is v2 of the changes submitted by Ben Shelton on August 4. I've reworked the patches quite a bit, larger changes include:

- All non-udev-cache-related patches have been omitted. I'll submit those separately.
- Use find to build tar filelist. This eliminates the need for GNU- and busybox-specific tar options.
- No new settings have been added to udev-cache.default in order to preserve compatibility with older overrides of udev-cache.default. Note, this means a lot of new settings are duplicated between initscripts.
- System config is now generated immediately before the tarball is generated, and is manipulated at the file level instead of the shell variable level.
- Internal/corporate commit message fields stripped.
- Spurious whitespace changes should all be fixed.

There is one requested fix I'm pushing back on: Copying both $CMP_FILE_LIST and /dev to tmpfs in a single operation to minimize race conditions. For a variety of reasons, I abandoned trying to make this work in a single command. Instead it's done in two: grabbing the system configuration (i.e reading /proc files and udev rules) is done first, then /dev is archived as an uncompressed tarball. Notably, using tar instead of cp means that I can use find -xdev and find -type to eliminate a lot of other complexity. I think this approach will wind up being faster than the straight-up copy approach, although I have not made any attempt to confirm that.

The following changes since commit 47d1fc9f5c38f3d092937c47bd4c2f45adaa7fe6:

qemu: fix Darwin cross-compilation (2014-08-18 20:43:24 +0100)

are available in the git repository at:

git://github.com/rtollert/openembedded-core dev/rtollert/udev-cache-7
https://github.com/rtollert/openembedded-core/tree/dev/rtollert/udev-cache-7

Richard Tollerton (12):
udev-cache: Update cache tarball atomically
udev-cache: Compress the cache
udev-cache: choose a more descriptive cache filename
busybox: enable tar -m
udev-cache: strip timestamps on extract
udev-cache: omit sockets and filesystems mounted under /dev
udev-cache: Don't ignore error messages from cache extract
udev-cache: parametrize sysconf file paths
udev-cache: get system config immediately before cache
udev-cache: invalidate on rules.d changes
udev-cache: Update cache asynchronously
udev-cache: refactor; improve verbosity and error handling

 meta/recipes-core/busybox/busybox/defconfig    |  2 +-
 meta/recipes-core/udev/udev/init               | 53 ++++++++++++--------------
 meta/recipes-core/udev/udev/udev-cache         | 42 ++++++++++++++++++--
 meta/recipes-core/udev/udev/udev-cache.default |  2 +-
 4 files changed, 64 insertions(+), 35 deletions(-)
Signature · 1 line
2.0.4