Skip to content

Several static analizer fixes

Mauro Carvalho Chehab linux-arm-kernel linux-media linux-samsung-soc 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest46 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/46dmxdev: don't use before checking file->private_datadrivers/media/dvb-core/dmxdev.c+1 -20 replies
2/46marvel-ccic: don't initialize static vars with 0drivers/media/platform/marvell-ccic/mcam-core.c+1 -10 replies
3/46soc_camera: use kmemdup()drivers/media/platform/soc_camera/soc_camera.c+1 -32 replies
4/46vivid-vid-out: use memdup_user()drivers/media/platform/vivid/vivid-vid-out.c+3 -72 replies
5/46s5k5baf: remove an uneeded semicolondrivers/media/i2c/s5k5baf.c+1 -10 replies
6/46bttv-driver: remove an uneeded semicolondrivers/media/pci/bt8xx/bttv-driver.c+1 -10 replies
7/46soc_camera: remove uneeded semicolonsdrivers/media/platform/soc_camera/pxa_camera.c drivers/media/platform/soc_camera/rcar_vin.c+2 -20 replies
8/46stv0900_core: don't allocate a temporary vardrivers/media/dvb-frontends/stv0900_core.c+2 -50 replies
9/46em28xx: use true/false for boolean varsdrivers/media/usb/em28xx/em28xx-input.c drivers/media/usb/em28xx/em28xx-video.c+5 -50 replies
10/46tuner-core: use true/false for boolean varsdrivers/media/v4l2-core/tuner-core.c+1 -10 replies
11/46af9013: use true/false for boolean varsdrivers/media/dvb-frontends/af9013.c+12 -120 replies
12/46cxd2820r: use true/false for boolean varsdrivers/media/dvb-frontends/cxd2820r_c.c drivers/media/dvb-frontends/cxd2820r_core.c drivers/media/dvb-frontends/cxd2820r_t.c+6 -60 replies
13/46m88ds3103: use true/false for boolean varsdrivers/media/dvb-frontends/m88ds3103.c+6 -60 replies
14/46af9013: use true/false for boolean varsdrivers/media/dvb-frontends/rtl2832.c drivers/media/dvb-frontends/rtl2832_sdr.c+2 -20 replies
15/46tda10071: use true/false for boolean varsdrivers/media/dvb-frontends/tda10071.c+1 -10 replies
16/46smiapp-core: use true/false for boolean varsdrivers/media/i2c/smiapp/smiapp-core.c+4 -42 replies
17/46ov9740: use true/false for boolean varsdrivers/media/i2c/soc_camera/ov9740.c+2 -20 replies
18/46omap3isp: use true/false for boolean varsdrivers/media/platform/omap3isp/ispccdc.c+1 -11 reply
19/46ti-vpe: use true/false for boolean varsdrivers/media/platform/ti-vpe/vpe.c+2 -20 replies
20/46vivid-tpg: use true/false for boolean varsdrivers/media/platform/vivid/vivid-tpg.c+2 -20 replies
21/46radio: use true/false for boolean varsdrivers/media/radio/radio-gemtek.c drivers/media/radio/radio-sf16fmi.c drivers/media/radio/si470x/radio-si470x-common.c+5 -50 replies
22/46ene_ir: use true/false for boolean varsdrivers/media/rc/ene_ir.c+1 -10 replies
23/46au0828-dvb: use true/false for boolean varsdrivers/media/usb/au0828/au0828-dvb.c+1 -10 replies
24/46lmedm04: use true/false for boolean varsdrivers/media/usb/dvb-usb-v2/lmedm04.c+1 -10 replies
25/46af9005: use true/false for boolean varsdrivers/media/usb/dvb-usb/af9005.c+1 -10 replies
26/46msi2500: simplify boolean testsdrivers/media/usb/msi2500/msi2500.c+1 -10 replies
27/46drxk_hard: simplify test logicdrivers/media/dvb-frontends/drxk_hard.c+17 -170 replies
28/46lm3560: simplify boolean testsdrivers/media/i2c/lm3560.c+2 -22 replies
29/46lm3560: simplify a boolean testdrivers/media/pci/zoran/zoran_device.c+1 -10 replies
30/46omap: simplify test logicdrivers/media/platform/omap/omap_vout.c drivers/media/platform/omap/omap_vout_vrfb.c+9 -90 replies
31/46via-camera: simplify boolean testsdrivers/media/platform/via-camera.c+1 -10 replies
32/46e4000: simplify boolean testsdrivers/media/tuners/e4000.c+2 -24 replies
33/46s5p-tv: Simplify the return logicdrivers/media/platform/s5p-tv/hdmi_drv.c drivers/media/platform/s5p-tv/sdo_drv.c drivers/media/platform/s5p-tv/sii9234_drv.c+3 -30 replies
34/46siano: just return 0 instead of using a vardrivers/media/common/siano/smscoreapi.c+1 -30 replies
35/46stv0367: just return 0 instead of using a vardrivers/media/dvb-frontends/stv0367.c+1 -30 replies
36/46media-devnode: just return 0 instead of using a vardrivers/media/media-devnode.c+1 -20 replies
37/46bt8xx: just return 0 instead of using a vardrivers/media/pci/bt8xx/bttv-driver.c drivers/media/pci/bt8xx/dst_ca.c+2 -50 replies
38/46saa7164: just return 0 instead of using a vardrivers/media/pci/saa7164/saa7164-api.c+1 -20 replies
39/46davinci: just return 0 instead of using a vardrivers/media/platform/davinci/vpfe_capture.c+1 -21 reply
40/46marvel-ccic: just return 0 instead of using a vardrivers/media/platform/exynos4-is/fimc-isp-video.c+1 -20 replies
41/46fintek-cir: just return 0 instead of using a vardrivers/media/rc/fintek-cir.c+2 -40 replies
42/46ite-cir: just return 0 instead of using a vardrivers/media/rc/ite-cir.c+1 -20 replies
43/46nuvoton-cir: just return 0 instead of using a vardrivers/media/rc/nuvoton-cir.c+2 -40 replies
44/46mt2060: just return 0 instead of using a vardrivers/media/tuners/mt2060.c+1 -20 replies
45/46mxl5005s: just return 0 instead of using a vardrivers/media/tuners/mxl5005s.c+1 -20 replies
46/46cx231xx: just return 0 instead of using a vardrivers/media/usb/cx231xx/cx231xx-dvb.c+1 -30 replies

Reviews trailers per patch

7 of 46 patches have a Reviewed-by or Acked-by.

PatchLad, PrabhakarGuennadi LiakhovetskiHans VerkuilRusty RussellSakari AilusLaurent PinchartDaniel Jeong
1/46
2/46
3/46A-b
4/46A-b
5/46
6/46
7/46
8/46
9/46
10/46
11/46
12/46
13/46
14/46
15/46
16/46A-b
17/46
18/46A-b
19/46
20/46
21/46
22/46
23/46
24/46
25/46
26/46
27/46
28/46A-b A-b
29/46
30/46
31/46
32/46R-b
33/46
34/46
35/46
36/46
37/46
38/46
39/46A-b
40/46
41/46
42/46
43/46
44/46
45/46
46/46

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v1 thread

Cover letter [PATCH 00/46] Several static analizer fixes

There are several small issues reported by static analyzers. Let's fix some of them on this patch series. One of this patch is a real bug (dmxdev one, at patch 01/46).

The other ones are just code cleanups.

The main goal is to be able to run a static analyzer test more frequently, so we want to have a cleaner report.

Mauro Carvalho Chehab (46):
[media] dmxdev: don't use before checking file->private_data [media] marvel-ccic: don't initialize static vars with 0 [media] soc_camera: use kmemdup()
[media] vivid-vid-out: use memdup_user()
[media] s5k5baf: remove an uneeded semicolon [media] bttv-driver: remove an uneeded semicolon [media] soc_camera: remove uneeded semicolons [media] stv0900_core: don't allocate a temporary var [media] em28xx: use true/false for boolean vars [media] tuner-core: use true/false for boolean vars [media] af9013: use true/false for boolean vars [media] cxd2820r: use true/false for boolean vars [media] m88ds3103: use true/false for boolean vars [media] af9013: use true/false for boolean vars [media] tda10071: use true/false for boolean vars [media] smiapp-core: use true/false for boolean vars [media] ov9740: use true/false for boolean vars [media] omap3isp: use true/false for boolean vars [media] ti-vpe: use true/false for boolean vars [media] vivid-tpg: use true/false for boolean vars [media] radio: use true/false for boolean vars [media] ene_ir: use true/false for boolean vars [media] au0828-dvb: use true/false for boolean vars [media] lmedm04: use true/false for boolean vars [media] af9005: use true/false for boolean vars [media] msi2500: simplify boolean tests
[media] drxk_hard: simplify test logic
[media] lm3560: simplify boolean tests
[media] lm3560: simplify a boolean test
[media] omap: simplify test logic
[media] via-camera: simplify boolean tests
[media] e4000: simplify boolean tests
[media] s5p-tv: Simplify the return logic
[media] siano: just return 0 instead of using a var [media] stv0367: just return 0 instead of using a var [media] media-devnode: just return 0 instead of using a var [media] bt8xx: just return 0 instead of using a var [media] saa7164: just return 0 instead of using a var [media] davinci: just return 0 instead of using a var [media] marvel-ccic: just return 0 instead of using a var [media] fintek-cir: just return 0 instead of using a var [media] ite-cir: just return 0 instead of using a var [media] nuvoton-cir: just return 0 instead of using a var [media] mt2060: just return 0 instead of using a var [media] mxl5005s: just return 0 instead of using a var [media] cx231xx: just return 0 instead of using a var

 drivers/media/common/siano/smscoreapi.c            |  4 +--
 drivers/media/dvb-core/dmxdev.c                    |  3 +-
 drivers/media/dvb-frontends/af9013.c               | 24 +++++++--------
 drivers/media/dvb-frontends/cxd2820r_c.c           |  4 +--
 drivers/media/dvb-frontends/cxd2820r_core.c        |  4 +--
 drivers/media/dvb-frontends/cxd2820r_t.c           |  4 +--
 drivers/media/dvb-frontends/drxk_hard.c            | 34 +++++++++++-----------
 drivers/media/dvb-frontends/m88ds3103.c            | 12 ++++----
 drivers/media/dvb-frontends/rtl2832.c              |  2 +-
 drivers/media/dvb-frontends/rtl2832_sdr.c          |  2 +-
 drivers/media/dvb-frontends/stv0367.c              |  4 +--
 drivers/media/dvb-frontends/stv0900_core.c         |  7 ++---
 drivers/media/dvb-frontends/tda10071.c             |  2 +-
 drivers/media/i2c/lm3560.c                         |  4 +--
 drivers/media/i2c/s5k5baf.c                        |  2 +-
 drivers/media/i2c/smiapp/smiapp-core.c             |  8 ++---
 drivers/media/i2c/soc_camera/ov9740.c              |  4 +--
 drivers/media/media-devnode.c                      |  3 +-
 drivers/media/pci/bt8xx/bttv-driver.c              |  5 ++--
 drivers/media/pci/bt8xx/dst_ca.c                   |  4 +--
 drivers/media/pci/saa7164/saa7164-api.c            |  3 +-
 drivers/media/pci/zoran/zoran_device.c             |  2 +-
 drivers/media/platform/davinci/vpfe_capture.c      |  3 +-
 drivers/media/platform/exynos4-is/fimc-isp-video.c |  3 +-
 drivers/media/platform/marvell-ccic/mcam-core.c    |  2 +-
 drivers/media/platform/omap/omap_vout.c            |  8 ++---
 drivers/media/platform/omap/omap_vout_vrfb.c       | 10 +++----
 drivers/media/platform/omap3isp/ispccdc.c          |  2 +-
 drivers/media/platform/s5p-tv/hdmi_drv.c           |  2 +-
 drivers/media/platform/s5p-tv/sdo_drv.c            |  2 +-
 drivers/media/platform/s5p-tv/sii9234_drv.c        |  2 +-
 drivers/media/platform/soc_camera/pxa_camera.c     |  2 +-
 drivers/media/platform/soc_camera/rcar_vin.c       |  2 +-
 drivers/media/platform/soc_camera/soc_camera.c     |  4 +--
 drivers/media/platform/ti-vpe/vpe.c                |  4 +--
 drivers/media/platform/via-camera.c                |  2 +-
 drivers/media/platform/vivid/vivid-tpg.c           |  4 +--
 drivers/media/platform/vivid/vivid-vid-out.c       | 10 ++-----
 drivers/media/radio/radio-gemtek.c                 |  2 +-
 drivers/media/radio/radio-sf16fmi.c                |  4 +--
 drivers/media/radio/si470x/radio-si470x-common.c   |  4 +--
 drivers/media/rc/ene_ir.c                          |  2 +-
 drivers/media/rc/fintek-cir.c                      |  6 ++--
 drivers/media/rc/ite-cir.c                         |  3 +-
 drivers/media/rc/nuvoton-cir.c                     |  6 ++--
 drivers/media/tuners/e4000.c                       |  4 +--
 drivers/media/tuners/mt2060.c                      |  3 +-
 drivers/media/tuners/mxl5005s.c                    |  3 +-
 drivers/media/usb/au0828/au0828-dvb.c              |  2 +-
 drivers/media/usb/cx231xx/cx231xx-dvb.c            |  4 +--
 drivers/media/usb/dvb-usb-v2/lmedm04.c             |  2 +-
 drivers/media/usb/dvb-usb/af9005.c                 |  2 +-
 drivers/media/usb/em28xx/em28xx-input.c            |  6 ++--
 drivers/media/usb/em28xx/em28xx-video.c            |  4 +--
 drivers/media/usb/msi2500/msi2500.c                |  2 +-
 drivers/media/v4l2-core/tuner-core.c               |  2 +-
 56 files changed, 117 insertions(+), 147 deletions(-)
Signature · 1 line
1.9.3