Skip to content

power_supply: Fixes & cleanups

Viresh Kumar linux-pm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15power-supply: Don't over-allocate memory for "supplied-from" arraydrivers/power/power_supply_core.c+1 -10 replies
2/15power-supply: Return early if "power-supplies" property isn't validdrivers/power/power_supply_core.c+4 -00 replies
3/15Documentation: Charger Manager: Fix spelling mistakesDocumentation/power/charger-manager.txt+1 -10 replies
4/15power-supply: Forward declare structs togetherinclude/linux/power_supply.h+1 -20 replies
5/15power-supply: Drop unnecessary typecastsdrivers/power/power_supply_core.c+4 -40 replies
6/15power-supply: Use 'break' instead of 'continue' to end loopdrivers/power/power_supply_core.c+2 -20 replies
7/15power-supply: Rearrange code to remove duplicate linesdrivers/power/power_supply_core.c+2 -20 replies
8/15power-supply: Propagate error returned by power_supply_find_supply_from_node()drivers/power/power_supply_core.c+2 -20 replies
9/15power-supply: Don't return -EINVAL from __power_supply_find_supply_from_node()drivers/power/power_supply_core.c+11 -70 replies
10/15power-supply: Drop useless 'if (ret.intval)' statementsdrivers/power/power_supply_core.c+5 -90 replies
11/15power-supply: Mark 'if' blocks in power_supply_changed_work() with 'likely'drivers/power/power_supply_core.c+13 -50 replies
12/15power-supply: Use PTR_ERR_OR_ZERO() routinedrivers/power/power_supply_core.c+2 -60 replies
13/15power-supply: Check for failures only when we can faildrivers/power/power_supply_sysfs.c+11 -100 replies
14/15power-supply: Avoid unnecessary 'goto' statementsdrivers/power/power_supply_core.c drivers/power/power_supply_leds.c+5 -170 replies
15/15power_supply: Don't iterate over devices to return -EPROBE_DEFERdrivers/power/power_supply_core.c+0 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/15] power_supply: Fixes & cleanups

Hi Guys,

I was required to work on a battery driver and found some fixes/cleanups while going through the core.

First two are fixes and rest are cleanups. Please see if they make any sense at all.

Pushed here: git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/linux.git battery/fixes

--
viresh

Viresh Kumar (15):
power-supply: Don't over-allocate memory for "supplied-from" array
power-supply: Return early if "power-supplies" property isn't valid
Documentation: Charger Manager: Fix spelling mistakes
power-supply: Forward declare structs together
power-supply: Drop unnecessary typecasts
power-supply: Use 'break' instead of 'continue' to end loop
power-supply: Rearrange code to remove duplicate lines
power-supply: Propagate error returned by
power_supply_find_supply_from_node()
power-supply: Don't return -EINVAL from
__power_supply_find_supply_from_node()
power-supply: Drop useless 'if (ret.intval)' statements
power-supply: Mark 'if' blocks in power_supply_changed_work() with
'likely'
power-supply: Use PTR_ERR_OR_ZERO() routine
power-supply: Check for failures only when we can fail
power-supply: Avoid unnecessary 'goto' statements
power_supply: Don't iterate over devices to return -EPROBE_DEFER

 Documentation/power/charger-manager.txt |   2 +-
 drivers/power/power_supply_core.c       | 100 +++++++++++++++-----------------
 drivers/power/power_supply_leds.c       |  19 ++----
 drivers/power/power_supply_sysfs.c      |  21 +++----
 include/linux/power_supply.h            |   3 +-
 5 files changed, 64 insertions(+), 81 deletions(-)
Signature · 1 line
2.0.3.693.g996b0fd