Skip to content

perf tool: improve error handling in perf_flag_probe()

Yann Droneaud lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY errortools/perf/util/cloexec.c+6 -20 replies
2/2perf tools: report PERF_FLAG_FD_CLOEXEC probing error oncetools/perf/util/cloexec.c+14 -120 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJiri Olsa
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] perf tool: improve error handling in perf_flag_probe()

Hi,

Following the EBUSY errors reported by Jiri Olsa [1], I've tryed to improve a bit the way perf_flag_probe() handle errors.

In case EBUSY is returned by perf_event_open(), testing the function again without PERF_FLAG_FD_CLOEXEC is meaningless: EBUSY is not related to close-on-exec flag, so there's nothing to confirm.

For other errors, not yet handled by perf_flag_probe(), it's pointless to report a second error message for the same error code:
the second check should not print an error if the error is the same as the one return for the first check.

[1] http://lkml.kernel.org/r/[email protected]

Yann Droneaud (2):
perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY
error
perf tools: report PERF_FLAG_FD_CLOEXEC probing error once

 tools/perf/util/cloexec.c | 28 +++++++++++++++++-----------
 1 file changed, 17 insertions(+), 11 deletions(-)
Cc Adrian Hunter <[email protected]>
Cc David Ahern <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Stephane Eranian <[email protected]>
Cc William Cohen <[email protected]>
Signature · 1 line
1.9.3