watchdog: add support for QCOM WDT
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 3 repliesIn review
- v33 patches 6 repliesSuperseded
- v23 patches 5 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 3 patches | 10 replies | Superseded |
Changes in v4 from the cover letter
- More error code cleanup, resolved nits
- Documented 'timeout-sec' property as optional
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | watchdog: qcom: add support for KPSS WDTdrivers/ drivers/ drivers/ | +200 | 1 reply | |
| 2/3 | watchdog: qcom: document device tree bindingsDocumentation/ | +24 | 1 reply | |
| 3/3 | watchdog: qcom: register a restart notifierdrivers/ | +38 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Guenter Roeck |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/3] watchdog: add support for QCOM WDT
This patchset provides support for the Watchdog Timer (WDT) found in the Krait Processor Sub-system (KPSS) of the MSM8960, APQ8064, and IPQ8064 chips.
This driver is implemented ontop of WATCHDOG_CORE, and therefore its primary interface is through userspace. The implemantion is currently very basic (i.e. it doesn't support PRETIMEOUT, even though it could be implemented through the WDT's BARK functionality). It should also be fairly easy to extend this driver in the future to support newer chipsets as well.
Patch 3 also extends the driver to also register a restart_notifier, making it possible for the WDT to act as a restart mechanism if more favorable mechanisms don't work. This is important for some boards which don't support PS_HOLD, like the IPQ8064-based AP148 board.
Changes since v3:
- More error code cleanup, resolved nits
- Documented 'timeout-sec' property as optional
Changes since v2:
- "input clock phandle" -> "input clock" in device tree documentation
- Fixup error handling paths during probe()
- Use a more sane timeout (128ms), and add msleep()
- Add some additional sanitation for clock rates
Changes since v1:
- Make use of clock API instead of using a 'clock-frequency' property
- Setup default timeout of 30 seconds when one is not specified
- Add remove() function to allow for module unloading
- Don't acquire/release watchdog lock on restart
- Don't bail completely if restart_handler registration fails
Josh Cartwright (3):
watchdog: qcom: add support for KPSS WDT
watchdog: qcom: document device tree bindings
watchdog: qcom: register a restart notifier
.../devicetree/bindings/watchdog/qcom-wdt.txt | 24 +++ drivers/watchdog/Kconfig | 13 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/qcom-wdt.c | 224 +++++++++++++++++++++ 4 files changed, 262 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt create mode 100644 drivers/watchdog/qcom-wdt.c
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation