Skip to content

Simplify cpuset API and fix cpuset check in SL[AU]B

Vladimir Davydov linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/24 patches 3 repliesIn review
  2. v1 posting 1/24 patches 5 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4cpuset: convert callback_mutex to a spinlockkernel/cpuset.c+55 -520 replies
2/4cpuset: simplify cpuset_node_allowed APIinclude/linux/cpuset.h kernel/cpuset.c mm/hugetlb.c +5 more+20 -923 replies
3/4slab: fix cpuset check in fallback_allocmm/slab.c+1 -10 replies
4/4slub: fix cpuset check in get_any_partialmm/slub.c+1 -20 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchChristoph LameterZefan LiVladimir Davydov
1/4A-b A-b
2/4A-b A-b A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH RESEND 0/4] Simplify cpuset API and fix cpuset check in SL[AU]B

[Rebased on top of 3.18-rc1 and added acks from Christoph and Zefan]

Hi,

SLAB and SLUB use hardwall cpuset check on fallback alloc, while the page allocator uses softwall check for all kernel allocations. This may result in falling into the page allocator even if there are free objects on other nodes. SLAB algorithm is especially affected: the number of objects allocated in vain is unlimited, so that they theoretically can eat up a whole NUMA node. For more details see comments to patches 3, 4.

When I last sent a fix (https://lkml.org/lkml/2014/8/10/100), David found the whole cpuset API being cumbersome and proposed to simplify it before getting to fixing its users. So this patch set addresses both David's complain (patches 1, 2) and the SL[AU]B issues (patches 3, 4).

Reviews are appreciated.

Thanks,

Vladimir Davydov (4):
cpuset: convert callback_mutex to a spinlock
cpuset: simplify cpuset_node_allowed API
slab: fix cpuset check in fallback_alloc
slub: fix cpuset check in get_any_partial

 include/linux/cpuset.h |   37 +++--------
 kernel/cpuset.c        |  162 +++++++++++++++++-------------------------------
 mm/hugetlb.c           |    2 +-
 mm/oom_kill.c          |    2 +-
 mm/page_alloc.c        |    6 +-
 mm/slab.c              |    2 +-
 mm/slub.c              |    2 +-
 mm/vmscan.c            |    5 +-
 8 files changed, 74 insertions(+), 144 deletions(-)
Signature · 7 lines
1.7.10.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>