Skip to content

seq_printf cleanups

Joe Perches cluster-devel linux-fsdevel linux-mtd lkml netdev netfilter-devel 1 version Applied

Status from this message: Applied to l2-mtd.git. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 29 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7seq_file: Rename static bool seq_overflow to public bool seq_is_fullDocumentation/filesystems/seq_file.txt fs/seq_file.c include/linux/seq_file.h+38 -263 replies
2/7netfilter: Convert print_tuple functions to return voidinclude/net/netfilter/nf_conntrack_core.h include/net/netfilter/nf_conntrack_l3proto.h include/net/netfilter/nf_conntrack_l4proto.h +9 more+46 -492 replies
3/7dlm: Use seq_is_full - remove seq_printf returnsfs/dlm/debug_fs.c+116 -1324 replies
4/7dlm: Use seq_puts, remove unnecessary trailing spacesfs/dlm/debug_fs.c+5 -70 replies
5/7fs: Convert show_fdinfo functions to voidDocumentation/filesystems/vfs.txt drivers/net/tun.c fs/eventfd.c +7 more+68 -933 replies
6/7debugfs: Fix misuse of seq_printf return valuefs/debugfs/file.c+8 -65 replies
7/7docg3: Fix miuse of seq_printf return valuedrivers/mtd/devices/docg3.c+52 -6010 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by.

PatchBrian NorrisGreg Kroah-Hartman
1/7
2/7
3/7
4/7
5/7
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] seq_printf cleanups

seq_printf should return void.

Add a public bool seq_is_full function that can be used to shortcut unnecesary seq_printf/seq_puts calls when the seq buffer is full.

Start removing the misuses of the seq_printf/seq_puts return value.

Patchset brought forward from an unreplied to set of changes from back in December 2013.

https://lkml.org/lkml/2013/12/11/713

Renamed seq_is_buf_full to seq_is_full.

Joe Perches (7):
seq_file: Rename static bool seq_overflow to public bool seq_is_full
netfilter: Convert print_tuple functions to return void
dlm: Use seq_is_full - remove seq_printf returns
dlm: Use seq_puts, remove unnecessary trailing spaces
fs: Convert show_fdinfo functions to void
debugfs: Fix misuse of seq_printf return value
docg3: Fix mixuse of seq_printf return value

 Documentation/filesystems/seq_file.txt       |  28 +--
 Documentation/filesystems/vfs.txt            |   2 +-
 drivers/mtd/devices/docg3.c                  | 112 ++++++------
 drivers/net/tun.c                            |   4 +-
 fs/debugfs/file.c                            |  14 +-
 fs/dlm/debug_fs.c                            | 260 +++++++++++++--------------
 fs/eventfd.c                                 |  15 +-
 fs/eventpoll.c                               |  19 +-
 fs/notify/fdinfo.c                           |  76 ++++----
 fs/notify/fdinfo.h                           |   4 +-
 fs/proc/fd.c                                 |   2 +-
 fs/seq_file.c                                |  28 +--
 fs/signalfd.c                                |  10 +-
 fs/timerfd.c                                 |  27 +--
 include/linux/fs.h                           |   2 +-
 include/linux/seq_file.h                     |   8 +
 include/net/netfilter/nf_conntrack_core.h    |   2 +-
 include/net/netfilter/nf_conntrack_l3proto.h |   4 +-
 include/net/netfilter/nf_conntrack_l4proto.h |   4 +-
 net/netfilter/nf_conntrack_l3proto_generic.c |   5 +-
 net/netfilter/nf_conntrack_proto_dccp.c      |  10 +-
 net/netfilter/nf_conntrack_proto_generic.c   |   5 +-
 net/netfilter/nf_conntrack_proto_gre.c       |  10 +-
 net/netfilter/nf_conntrack_proto_sctp.c      |  10 +-
 net/netfilter/nf_conntrack_proto_tcp.c       |  10 +-
 net/netfilter/nf_conntrack_proto_udp.c       |  10 +-
 net/netfilter/nf_conntrack_proto_udplite.c   |  10 +-
 net/netfilter/nf_conntrack_standalone.c      |  15 +-
 28 files changed, 333 insertions(+), 373 deletions(-)
Signature · 1 line
1.8.1.2.459.gbcd45b4.dirty