Skip to content

audit fsnotify cleanups for watches and trees

Richard Guy Briggs linux-audit lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7audit: put rule existence check in canonical orderkernel/auditfilter.c+1 -10 replies
2/7audit: cull redundancy in audit_rule_changekernel/auditfilter.c+7 -131 reply
3/7audit: eliminate string copy for new tree ruleskernel/audit_tree.c kernel/auditfilter.c+8 -61 reply
4/7audit: optimize add to parent skipping needless search and consuming parent refkernel/audit_watch.c+15 -81 reply
5/7audit: remove redundant watch refcountkernel/audit_watch.c kernel/auditfilter.c+1 -111 reply
6/7audit: remove extra audit_get_parent()kernel/audit_watch.c+0 -10 replies
7/7audit: rename audit_log_remove_rule to disambiguate for treeskernel/audit_tree.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] audit fsnotify cleanups for watches and trees

This is a collection of patches to clean up some issues discovered while implementing audit by exe path.

They compile and have been lightly tested.

I'd be interested in feedback about approaches or details or grossly misunderstanding some fundamental concepts.

Thanks!

Richard Guy Briggs (7):
audit: put rule existence check in canonical order
audit: cull redundancy in audit_rule_change
audit: eliminate string copy for new tree rules
audit: optimize add to parent skipping needless search and consuming
parent ref
audit: remove redundant watch refcount
audit: remove extra audit_get_parent()
audit: rename audit_log_remove_rule to disambiguate for trees

 kernel/audit_tree.c  |   13 +++++++------
 kernel/audit_watch.c |   29 ++++++++++++++++-------------
 kernel/auditfilter.c |   34 +++++++++++-----------------------
 3 files changed, 34 insertions(+), 42 deletions(-)