Skip to content

drm/i915: hdmi/dp audio rework

Jani Nikula dri-devel intel-gfx nouveau 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest18 patches 28 repliesIn review
  2. v118 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18drm/i915: add new intel audio file to group DP/HDMI audiodrivers/gpu/drm/i915/Makefile drivers/gpu/drm/i915/intel_audio.c drivers/gpu/drm/i915/intel_display.c +1 more+368 -3231 reply
2/18drm/i915/audio: constify hdmi audio clock structdrivers/gpu/drm/i915/intel_audio.c+1 -11 reply
3/18drm/i915/audio: beat some sense into the variable types and namesdrivers/gpu/drm/i915/intel_audio.c+57 -581 reply
4/18drm/i915: pass intel_encoder to intel_write_elddrivers/gpu/drm/i915/intel_audio.c drivers/gpu/drm/i915/intel_ddi.c drivers/gpu/drm/i915/intel_dp.c +2 more+9 -91 reply
5/18drm/i915/audio: pass intel_encoder on to platform specific ELD functionsdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_audio.c+12 -146 replies
6/18drm/i915/audio: set ELD Conn_Type at one placedrivers/gpu/drm/i915/intel_audio.c+9 -104 replies
7/18drm/i915/ddi: write ELD where it's supposed to be donedrivers/gpu/drm/i915/intel_audio.c drivers/gpu/drm/i915/intel_ddi.c+2 -113 replies
8/18drm/i915: introduce intel_audio_codec_{enable, disable}drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_audio.c drivers/gpu/drm/i915/intel_ddi.c +3 more+73 -411 reply
9/18drm/i915/audio: remove misleading checks for !eld[0]drivers/gpu/drm/i915/intel_audio.c+0 -123 replies
10/18drm/i915: clean up and clarify audio related register definesdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_audio.c+89 -881 reply
11/18drm/i915: rewrite hsw/bdw audio codec enable/disable sequencesdrivers/gpu/drm/i915/intel_audio.c+46 -6410 replies
12/18drm/i915/audio: rewrite vlv/chv and gen 5-7 audio codec enable sequencedrivers/gpu/drm/i915/intel_audio.c+26 -327 replies
13/18drm/i915/audio: add vlv/chv/gen5-7 audio codec disable sequencedrivers/gpu/drm/i915/intel_audio.c drivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_hdmi.c+60 -01 reply
14/18drm/i915: enable audio codec after portdrivers/gpu/drm/i915/intel_dp.c drivers/gpu/drm/i915/intel_hdmi.c+15 -131 reply
15/18drm/i915/audio: add audio codec disable on g4xdrivers/gpu/drm/i915/intel_audio.c+20 -01 reply
16/18drm/i915/audio: add audio codec enable debug log for g4xdrivers/gpu/drm/i915/intel_audio.c+2 -01 reply
17/18drm/i915: make pipe/port based audio valid accessors easier to usedrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_audio.c drivers/gpu/drm/i915/intel_ddi.c+17 -271 reply
18/18drm/i915/audio: add DOC comment describing HDA over HDMI/DPDocumentation/DocBook/drm.tmpl drivers/gpu/drm/i915/intel_audio.c+26 -01 reply

Reviews trailers per patch

17 of 18 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRodrigo ViviBen Skeggs
SeriesR-b R-b A-b
1/18R-b
2/18R-b
3/18R-b
4/18R-b
5/18R-b
6/18R-b
7/18R-b
8/18R-b
9/18R-b
10/18R-b
11/18R-b
12/18
13/18R-b
14/18R-b
15/18R-b
16/18R-b
17/18R-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/18] drm/i915: hdmi/dp audio rework

This is v2 of [1]. No functional changes since the last version; just a rebase on top of current nightly, and some kerneldoc improvements.

BR,
Jani.

[1] http://mid.gmane.org/[email protected]

Jani Nikula (18):
drm/i915: add new intel audio file to group DP/HDMI audio drm/i915/audio: constify hdmi audio clock struct drm/i915/audio: beat some sense into the variable types and names drm/i915: pass intel_encoder to intel_write_eld drm/i915/audio: pass intel_encoder on to platform specific ELD
functions
drm/i915/audio: set ELD Conn_Type at one place drm/i915/ddi: write ELD where it's supposed to be done drm/i915: introduce intel_audio_codec_{enable,disable} drm/i915/audio: remove misleading checks for !eld[0] drm/i915: clean up and clarify audio related register defines drm/i915: rewrite hsw/bdw audio codec enable/disable sequences drm/i915/audio: rewrite vlv/chv and gen 5-7 audio codec enable
sequence
drm/i915/audio: add vlv/chv/gen5-7 audio codec disable sequence drm/i915: enable audio codec after port
drm/i915/audio: add audio codec disable on g4x drm/i915/audio: add audio codec enable debug log for g4x drm/i915: make pipe/port based audio valid accessors easier to use drm/i915/audio: add DOC comment describing HDA over HDMI/DP

 Documentation/DocBook/drm.tmpl       |   5 +
 drivers/gpu/drm/i915/Makefile        |   3 +-
 drivers/gpu/drm/i915/i915_drv.h      |   9 +-
 drivers/gpu/drm/i915/i915_reg.h      | 181 +++++++-------
 drivers/gpu/drm/i915/intel_audio.c   | 452 +++++++++++++++++++++++++++++++++++
 drivers/gpu/drm/i915/intel_ddi.c     |  26 +-
 drivers/gpu/drm/i915/intel_display.c | 323 +------------------------
 drivers/gpu/drm/i915/intel_dp.c      |  17 +-
 drivers/gpu/drm/i915/intel_drv.h     |   8 +-
 drivers/gpu/drm/i915/intel_hdmi.c    |  19 +-
 10 files changed, 586 insertions(+), 457 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/intel_audio.c
Signature · 6 lines
2.1.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Read the cover letter in its thread