Coverity patches for drivers/isdn
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest12 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | isdn/gigaset: missing break in do_facility_reqdrivers/ | +1 | 0 replies | |
| 2/12 | isdn/gigaset: make sure controller name is null terminateddrivers/ | +2 | 0 replies | |
| 3/12 | isdn/gigaset: limit raw CAPI message dump lengthdrivers/ | +2 | 0 replies | |
| 4/12 | isdn/gigaset: fix NULL pointer dereferencedrivers/ | +5 | 0 replies | |
| 5/12 | isdn/gigaset: fix non-heap pointer deallocationdrivers/ | +70 | 0 replies | |
| 6/12 | isdn/capi: correct capi20_manufacturer argument type mismatchdrivers/ include/ | +3 | 0 replies | |
| 7/12 | isdn/capi: prevent index overrun from command_2_index()drivers/ | +2 | 0 replies | |
| 8/12 | isdn/capi: refactor command/subcommand table accessesdrivers/ | +18 | 0 replies | |
| 9/12 | isdn/capi: prevent NULL pointer dereference on invalid CAPI commanddrivers/ | +7 | 0 replies | |
| 10/12 | isdn/capi: handle CAPI 2.0 message parser failuresdrivers/ drivers/ | +145 | 0 replies | |
| 11/12 | isdn/capi: don't return NULL from capi_cmd2str()drivers/ | +7 | 0 replies | |
| 12/12 | isdn/gigaset: fix usb_gigaset write_cmd result racedrivers/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/12] Coverity patches for drivers/isdn
Here's a series of patches for the ISDN CAPI subsystem and the Gigaset ISDN driver.
Patches 1 to 7 are specific fixes for Coverity warnings. Patches 8 to 11 fix related problems with the handling of invalid CAPI command codes I noticed while working on this. Patch 12 fixes an unrelated problem I noticed during the subsequent regression tests.
It would be great if these could still be merged.
Thanks,
Tilman
Tilman Schmidt (12):
isdn/gigaset: missing break in do_facility_req isdn/gigaset: make sure controller name is null terminated isdn/gigaset: limit raw CAPI message dump length isdn/gigaset: fix NULL pointer dereference
isdn/gigaset: fix non-heap pointer deallocation isdn/capi: correct capi20_manufacturer argument type mismatch isdn/capi: prevent index overrun from command_2_index() isdn/capi: refactor command/subcommand table accesses isdn/capi: prevent NULL pointer dereference on invalid CAPI command isdn/capi: handle CAPI 2.0 message parser failures isdn/capi: don't return NULL from capi_cmd2str() isdn/gigaset: fix usb_gigaset write_cmd result race
drivers/isdn/capi/capidrv.c | 24 +++++- drivers/isdn/capi/capiutil.c | 41 ++++++++-- drivers/isdn/capi/kcapi.c | 4 +- drivers/isdn/gigaset/capi.c | 155 +++++++++++++++++++++++++++++++------ drivers/isdn/gigaset/ev-layer.c | 116 +++++++++++++++++---------- drivers/isdn/gigaset/usb-gigaset.c | 4 +- include/linux/kernelcapi.h | 2 +- 7 files changed, 265 insertions(+), 81 deletions(-)
Signature · 1 line
1.9.2.459.g68773ac