Skip to content

treewide: mask then shift defects and style updates

Joe Perches alsa-devel dri-devel linux-input linux-media linux-nvme linux-parisc linux-wireless lkml netdev 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 15 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/11block: nvme-scsi: Fix probable mask then right shift defectsdrivers/block/nvme-scsi.c+6 -61 reply
2/11radeon: evergreen: Fix probable mask then right shift defectsdrivers/gpu/drm/radeon/evergreen.c+2 -15 replies
3/11aiptek: Fix probable mask then right shift defectsdrivers/input/tablet/aiptek.c+3 -34 replies
4/11dvb-net: Fix probable mask then right shift defectsdrivers/media/dvb-core/dvb_net.c+3 -10 replies
5/11cx25840/cx18: Use standard ordering of mask and shiftdrivers/media/i2c/cx25840/cx25840-core.c drivers/media/pci/cx18/cx18-av-core.c+14 -141 reply
6/11wm8350-core: Fix probable mask then right shift defectdrivers/mfd/wm8350-core.c+1 -12 replies
7/11iwlwifi: dvm: Fix probable mask then right shift defectdrivers/net/wireless/iwlwifi/dvm/lib.c+2 -21 reply
8/11ssb: driver_chip_comon_pmu: Fix probable mask then right shift defectdrivers/ssb/driver_chipcommon_pmu.c+2 -21 reply
9/11tty: ipwireless: Fix probable mask then right shift defectsdrivers/tty/ipwireless/hardware.c+6 -63 replies
10/11hwa-hc: Fix probable mask then right shift defectdrivers/usb/host/hwa-hc.c+1 -10 replies
11/11sound: ad1889: Fix probable mask then right shift defectssound/pci/ad1889.c+4 -41 reply

Reviews trailers per patch

6 of 11 patches have a Reviewed-by or Acked-by.

PatchCharles KeepaxDavid SterbaJiri KosinaMichael BüschMichel DänzerAndy WallsVishal Verma
1/11A-b
2/11R-b
3/11
4/11
5/11R-b
6/11A-b
7/11
8/11R-b
9/11A-b R-b
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v1 thread

Cover letter [PATCH 00/11] treewide: mask then shift defects and style updates

logical mask has lower precedence than shift but should be done before the shift so parentheses are generally required.

And when masking with a fixed value after a shift, normal kernel style has the shift on the left, then the shift on the right so convert a few non-conforming uses.

Joe Perches (11):
block: nvme-scsi: Fix probable mask then right shift defects
radeon: evergreen: Fix probable mask then right shift defects
aiptek: Fix probable mask then right shift defects
dvb-net: Fix probable mask then right shift defects cx25840/cx18: Use standard ordering of mask and shift
wm8350-core: Fix probable mask then right shift defect
iwlwifi: dvm: Fix probable mask then right shift defect
ssb: driver_chip_comon_pmu: Fix probable mask then right shift defect
tty: ipwireless: Fix probable mask then right shift defects
hwa-hc: Fix probable mask then right shift defect
sound: ad1889: Fix probable mask then right shift defects

 drivers/block/nvme-scsi.c                | 12 ++++++------
 drivers/gpu/drm/radeon/evergreen.c       |  3 ++-
 drivers/input/tablet/aiptek.c            |  6 +++---
 drivers/media/dvb-core/dvb_net.c         |  4 +++-
 drivers/media/i2c/cx25840/cx25840-core.c | 12 ++++++------
 drivers/media/pci/cx18/cx18-av-core.c    | 16 ++++++++--------
 drivers/mfd/wm8350-core.c                |  2 +-
 drivers/net/wireless/iwlwifi/dvm/lib.c   |  4 ++--
 drivers/ssb/driver_chipcommon_pmu.c      |  4 ++--
 drivers/tty/ipwireless/hardware.c        | 12 ++++++------
 drivers/usb/host/hwa-hc.c                |  2 +-
 sound/pci/ad1889.c                       |  8 ++++----
 12 files changed, 44 insertions(+), 41 deletions(-)
Signature · 1 line
2.1.2