Skip to content

lgdt3306a: Fix several sparse/smatch/CodingStyle issues

Mauro Carvalho Chehab linux-media 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13lgdt3306a: Use hexadecimal values in lowercasedrivers/media/dvb-frontends/lgdt3306a.c+230 -2300 replies
2/13lgdt3306a: Use IS_ENABLED() for attach functiondrivers/media/dvb-frontends/lgdt3306a.c drivers/media/dvb-frontends/lgdt3306a.h+4 -60 replies
3/13lgdt3306a: one bit fields should be unsigneddrivers/media/dvb-frontends/lgdt3306a.h+2 -20 replies
4/13lgdt3306a: don't go past the bufferdrivers/media/dvb-frontends/lgdt3306a.c+10 -80 replies
5/13lgdt3306a: properly handle I/O errorsdrivers/media/dvb-frontends/lgdt3306a.c+79 -50 replies
6/13lgdt3306a: Remove FSF addressdrivers/media/dvb-frontends/lgdt3306a.c drivers/media/dvb-frontends/lgdt3306a.h+1 -100 replies
7/13lbdt3306a: rework at printk macrosdrivers/media/dvb-frontends/lgdt3306a.c+89 -830 replies
8/13lbdt3306a: simplify the lock status checkdrivers/media/dvb-frontends/lgdt3306a.c+28 -400 replies
9/13lgdt3306a: Don't use else were not neededdrivers/media/dvb-frontends/lgdt3306a.c+6 -60 replies
10/13lbdt3306a: remove uneeded bracesdrivers/media/dvb-frontends/lgdt3306a.c+2 -30 replies
11/13lgdt3306a: constify log tablesdrivers/media/dvb-frontends/lgdt3306a.c+9 -50 replies
12/13lgdt3306a: Break long linesdrivers/media/dvb-frontends/lgdt3306a.c+91 -430 replies
13/13lgdt3306a: Minor source code cleanupsdrivers/media/dvb-frontends/lgdt3306a.c drivers/media/dvb-frontends/lgdt3306a.h+12 -210 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] lgdt3306a: Fix several sparse/smatch/CodingStyle issues

The submitted lgdt3306a driver was not in a good shape for merging. However, as most of the issues are trivial, I solved them.

There are still a few remaining issues:

- As reported by checkpatch.pl:
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

Who will maintain it?

- There's currently no driver using this demod;

- It is still using DVBv3 stats. I can fix it, but I need the patches that will add support for the boards that use this demod in order to take a look on it;

- It uses its own log implementation.

For now, I'll be merging this on a topic branch, until the above issues get fixed.

Mauro Carvalho Chehab (13):
[media] lgdt3306a: Use hexadecimal values in lowercase [media] lgdt3306a: Use IS_ENABLED() for attach function [media] lgdt3306a: one bit fields should be unsigned [media] lgdt3306a: don't go past the buffer [media] lgdt3306a: properly handle I/O errors [media] lgdt3306a: Remove FSF address
[media] lbdt3306a: rework at printk macros [media] lbdt3306a: simplify the lock status check [media] lgdt3306a: Don't use else were not needed [media] lbdt3306a: remove uneeded braces [media] lgdt3306a: constify log tables
[media] lgdt3306a: Break long lines
[media] lgdt3306a: Minor source code cleanups

 drivers/media/dvb-frontends/lgdt3306a.c | 979 ++++++++++++++++++--------------
 drivers/media/dvb-frontends/lgdt3306a.h |  18 +-
 2 files changed, 549 insertions(+), 448 deletions(-)
Signature · 1 line
1.9.3