lgdt3306a: Fix several sparse/smatch/CodingStyle issues
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest13 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | lgdt3306a: Use hexadecimal values in lowercasedrivers/ | +230 | 0 replies | |
| 2/13 | lgdt3306a: Use IS_ENABLED() for attach functiondrivers/ drivers/ | +4 | 0 replies | |
| 3/13 | lgdt3306a: one bit fields should be unsigneddrivers/ | +2 | 0 replies | |
| 4/13 | lgdt3306a: don't go past the bufferdrivers/ | +10 | 0 replies | |
| 5/13 | lgdt3306a: properly handle I/O errorsdrivers/ | +79 | 0 replies | |
| 6/13 | lgdt3306a: Remove FSF addressdrivers/ drivers/ | +1 | 0 replies | |
| 7/13 | lbdt3306a: rework at printk macrosdrivers/ | +89 | 0 replies | |
| 8/13 | lbdt3306a: simplify the lock status checkdrivers/ | +28 | 0 replies | |
| 9/13 | lgdt3306a: Don't use else were not neededdrivers/ | +6 | 0 replies | |
| 10/13 | lbdt3306a: remove uneeded bracesdrivers/ | +2 | 0 replies | |
| 11/13 | lgdt3306a: constify log tablesdrivers/ | +9 | 0 replies | |
| 12/13 | lgdt3306a: Break long linesdrivers/ | +91 | 0 replies | |
| 13/13 | lgdt3306a: Minor source code cleanupsdrivers/ drivers/ | +12 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/13] lgdt3306a: Fix several sparse/smatch/CodingStyle issues
The submitted lgdt3306a driver was not in a good shape for merging. However, as most of the issues are trivial, I solved them.
There are still a few remaining issues:
- As reported by checkpatch.pl:
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
Who will maintain it?
- There's currently no driver using this demod;
- It is still using DVBv3 stats. I can fix it, but I need the patches that will add support for the boards that use this demod in order to take a look on it;
- It uses its own log implementation.
For now, I'll be merging this on a topic branch, until the above issues get fixed.
Mauro Carvalho Chehab (13):
[media] lgdt3306a: Use hexadecimal values in lowercase [media] lgdt3306a: Use IS_ENABLED() for attach function [media] lgdt3306a: one bit fields should be unsigned [media] lgdt3306a: don't go past the buffer [media] lgdt3306a: properly handle I/O errors [media] lgdt3306a: Remove FSF address
[media] lbdt3306a: rework at printk macros [media] lbdt3306a: simplify the lock status check [media] lgdt3306a: Don't use else were not needed [media] lbdt3306a: remove uneeded braces [media] lgdt3306a: constify log tables
[media] lgdt3306a: Break long lines
[media] lgdt3306a: Minor source code cleanups
drivers/media/dvb-frontends/lgdt3306a.c | 979 ++++++++++++++++++-------------- drivers/media/dvb-frontends/lgdt3306a.h | 18 +- 2 files changed, 549 insertions(+), 448 deletions(-)
Signature · 1 line
1.9.3