cleanup -daemonize and pidfile creation a bit
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | os-posix: use global daemon_pipe instead of cryptic fds[1]os-posix.c | +6 | 1 reply | |
| 2/4 | os-posix: replace goto again with a proper loopos-posix.c | +6 | 1 reply | |
| 3/4 | pidfile: stop making pidfile error a special caseinclude/ os-posix.c os-win32.c +1 more | +7 | 7 replies | |
| 4/4 | os-posix: reorder parent notification for -daemonizeos-posix.c | +10 | 1 reply |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Gonglei |
|---|---|
| 1/4 | R-b |
| 2/4 | R-b |
| 3/4 | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 0/4] cleanup -daemonize and pidfile creation a bit
The $subject theme is quite messy, with many things done in a cryptic and twisty way without any need for that. This trivial patch series tries to clean up and improve it. In particular, it aims to make pidfile errors visible with -daemonize -- something which Gonglei tried to fix in e5048d15ce6a and which we're revering because that fix turned out to be incomplete and wrong.
The patches are simple but I split them into several to easy review.
Michael Tokarev (4):
os-posix: use global daemon_pipe instead of cryptic fds[1]
os-posix: replace goto again with a proper loop
pidfile: stop making pidfile error a special case
os-posix: reorder parent notification for -daemonize
include/qemu-common.h | 1 - os-posix.c | 62 ++++++++++++++++++------------------------------- os-win32.c | 5 ---- vl.c | 2 +- 4 files changed, 23 insertions(+), 47 deletions(-)
Signature · 1 line
1.7.10.4