Skip to content

gtk: Hide menubar in fullscreen mode (lp 1294898)

Cole Robinson qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4gtk: Grab accel_group from GtkDisplayStateui/gtk.c+9 -120 replies
2/4gtk: Install fullscreen accelerator on toplevel windowui/gtk.c+14 -40 replies
3/4gtk: Install vc accelerators on parent windowui/gtk.c+15 -70 replies
4/4gtk: Hide the menubar when in fullscreen mode (lp 1294898)ui/gtk.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/4] gtk: Hide menubar in fullscreen mode (lp 1294898)

When compiled against gtk3, the gtk UI menubar is visible in fullscreen mode, taking up space and annoying users. This series attempts to fix that.

The main blocker is that when the menu bar is hidden, we lose access to the keyboard shortcuts associated with all the menu items, most importantly the one to actually _exit_ fullscreen mode. We fix this by installing the shortcuts on the top level windows (However this has a minor downside on gtk < 3.8, see patch 2 for details.)

Cole Robinson (4):
gtk: Grab accel_group from GtkDisplayState
gtk: Install fullscreen accelerator on toplevel window
gtk: Install vc accelerators on parent window
gtk: Hide the menubar when in fullscreen mode (lp 1294898)

 ui/gtk.c | 65 +++++++++++++++++++++++++++++++++++++++-------------------------
 1 file changed, 40 insertions(+), 25 deletions(-)
Signature · 1 line
2.1.0