Skip to content

ACPI / EC: Add reference counting for requests and cleans up the grace periods support.

Lv Zheng linux-acpi lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 4 repliesIn review
  2. v16 patches 18 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ACPI / EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag.drivers/acpi/ec.c+54 -110 replies
2/5ACPI / EC: Add command flushing support.drivers/acpi/ec.c drivers/acpi/internal.h+66 -30 replies
3/5ACPI / EC: Refine command storm prevention support.drivers/acpi/ec.c+36 -190 replies
4/5ACPI / EC: Add query flushing support.drivers/acpi/ec.c+85 -160 replies
5/5ACPI / EC: Add GPE reference counting debugging messages.drivers/acpi/ec.c+22 -20 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchOrtwin Glück
1/5T-b
2/5T-b
3/5
4/5T-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] ACPI / EC: Add reference counting for requests and cleans up the grace periods support.

This patchset contains 3 cleanups related to the EC driver:
1. Command flushing (command grace period)
This patchset flushes EC commands before suspending/resuming, so that there won't be timeout for the incomplete commands after resuming.
2. Query flushing (query grace period)
This patchset flushes EC event queries before suspending/resuming, so that there won't be broken events remained in the firmware queue.
3. Command storming prevention
This patchset corrects command storming prevention logic because of the GPE raw handler mode.
The request reference count debugging messages can be used to detect broken EC transactions. It should always drop to 1 when the driver is idle during the runtime.

Note that after flushing before suspending, EC GPE is still enabled to keep the old behavior.

Lv Zheng (5):
ACPI/EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag. ACPI/EC: Add command flushing support.
ACPI/EC: Refine command storm prevention support. ACPI/EC: Add query flushing support.
ACPI/EC: Add GPE reference counting debugging messages.

 drivers/acpi/ec.c       |  295 ++++++++++++++++++++++++++++++++++++++++-------
 drivers/acpi/internal.h |    1 +
 2 files changed, 254 insertions(+), 42 deletions(-)
Signature · 1 line
1.7.10