RFC pci cleanup: remove pci_config_set_*
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest6 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | pci: remove pci_config_set_vendor_idhw/ include/ | +1 | 0 replies | |
| 2/6 | pci: remove pci_config_set_device_idhw/ include/ | +1 | 0 replies | |
| 3/6 | pci: remove pci_config_set_revisionhw/ include/ | +1 | 0 replies | |
| 4/6 | pci: remove pci_config_set_classhw/ hw/ hw/ +3 more | +5 | 0 replies | |
| 5/6 | pci: remove pci_config_set_prog_interfacehw/ hw/ hw/ +7 more | +9 | 0 replies | |
| 6/6 | pci: remove pci_config_set_interrupt_pinhw/ hw/ hw/ +6 more | +8 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Qemu-devel] [RFC PATCH 0/6] pci cleanup: remove pci_config_set_*
Hi,
This series removes pci_config_set_*. The main purpose is for API consistency. Detailed reasons:
- pci_config_set_* are not complete. 1) Only part of registers in predefined header portion of PCI Configuration Space are supported. 2) Lack of get_ counterparts.
- pci_set_word() and friends are extensively used in qemu. They are used both for predefined registers and device specific registers.
- another option is to complete the pci_config_set_* for all predefined registers (though they will co-exist with pci_set_*). Hence the RFC.
Hu Tao (6):
pci: remove pci_config_set_vendor_id
pci: remove pci_config_set_device_id
pci: remove pci_config_set_revision
pci: remove pci_config_set_class
pci: remove pci_config_set_prog_interface
pci: remove pci_config_set_interrupt_pin
hw/audio/intel-hda.c | 2 +- hw/block/nvme.c | 4 ++-- hw/i2c/smbus_ich9.c | 2 +- hw/i386/xen/xen_platform.c | 2 +- hw/i386/xen/xen_pvdevice.c | 2 +- hw/ide/ich.c | 4 ++-- hw/ide/via.c | 2 +- hw/isa/i82378.c | 2 +- hw/isa/vt82c686.c | 2 +- hw/mips/gt64xxx_pci.c | 2 +- hw/misc/ivshmem.c | 2 +- hw/misc/vfio.c | 2 +- hw/pci-bridge/i82801b11.c | 2 +- hw/pci-host/bonito.c | 2 +- hw/pci-host/ppce500.c | 2 +- hw/pci/pci.c | 8 ++++---- hw/pci/pci_bridge.c | 2 +- hw/scsi/vmw_pvscsi.c | 2 +- hw/usb/hcd-uhci.c | 2 +- hw/virtio/virtio-pci.c | 2 +- include/hw/pci/pci.h | 36 ------------------------------------ 21 files changed, 25 insertions(+), 61 deletions(-)
Signature · 1 line
1.9.3