Skip to content

cpufreq: Register cooling device after policy is ready

Viresh Kumar linux-pm 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v17 patches 13 repliesSuperseded

Changes in v2 from the cover letter

- s/usable/ready
- dropped last three patches that broke thermal somehow.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4cpufreq: Fix formatting issues in 'struct cpufreq_driver'include/linux/cpufreq.h+25 -250 replies
2/4cpufreq-dt: pass 'policy->related_cpus' to of_cpufreq_cooling_register()drivers/cpufreq/cpufreq-dt.c+1 -10 replies
3/4cpufreq: Introduce ->ready() callback for cpufreq driversdrivers/cpufreq/cpufreq.c include/linux/cpufreq.h+9 -01 reply
4/4cpufreq-dt: register cooling device from ->ready() callbackdrivers/cpufreq/cpufreq-dt.c+32 -191 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchEduardo ValentinLukasz Majewski
1/4R-b T-b
2/4R-b T-b
3/4R-b T-b R-b
4/4R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/4] cpufreq: Register cooling device after policy is ready

Hi Rafael/Eduardo,

Currently there is no callback for cpufreq drivers which is called once the policy is ready to be used. There are some requirements where such a callback is required.

One of them is registering a cooling device with the help of of_cpufreq_cooling_register(). This routine tries to get 'struct cpufreq_policy' for CPUs which isn't yet initialed at the time ->init() is called and so we face issues while registering the cooling device.

Because we can't register cooling device from ->init(), we need a callback that is called after the policy is ready to be used and hence ->ready() callback.

The first patch fixes few formatting issues, so that the third patch doesn't throw any checkpatch warnings. Second one fixes a potential bug in cpufreq-dt driver. Third one introduces ->ready() callback which will be used in the fourth patch.

V1->V2:
- s/usable/ready
- dropped last three patches that broke thermal somehow.

Viresh Kumar (4):
cpufreq: Fix formatting issues in 'struct cpufreq_driver'
cpufreq-dt: pass 'policy->related_cpus' to
of_cpufreq_cooling_register()
cpufreq: Introduce ->ready() callback for cpufreq drivers
cpufreq-dt: register cooling device from ->ready() callback

 drivers/cpufreq/cpufreq-dt.c | 51 +++++++++++++++++++++++++----------------
 drivers/cpufreq/cpufreq.c    |  5 ++++
 include/linux/cpufreq.h      | 54 ++++++++++++++++++++++++--------------------
 3 files changed, 66 insertions(+), 44 deletions(-)
Signature · 1 line
2.0.3.693.g996b0fd