Skip to content

bridge: Fix missing Netlink message validations

Thomas Graf netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5bridge: Validate IFLA_BRIDGE_FLAGS attribute lengthnet/core/rtnetlink.c+6 -00 replies
2/5net: Validate IFLA_BRIDGE_MODE attribute lengthdrivers/net/ethernet/emulex/benet/be_main.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+6 -02 replies
3/5net: Check for presence of IFLA_AF_SPECdrivers/net/ethernet/emulex/benet/be_main.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+4 -01 reply
4/5bridge: Add missing policy entry for IFLA_BRPORT_FAST_LEAVEnet/bridge/br_netlink.c+1 -00 replies
5/5bridge: Sanitize IFLA_EXT_MASK for AF_BRIDGE:RTM_GETLINKnet/core/rtnetlink.c+12 -50 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchJeff KirsherJohn Fastabend
1/5
2/5A-b A-b
3/5A-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5 net] bridge: Fix missing Netlink message validations

Adds various missing length checks in the bridging code for Netlink messages and corresponding attributes provided by user space.

Thomas Graf (5):
bridge: Validate IFLA_BRIDGE_FLAGS attribute length
net: Validate IFLA_BRIDGE_MODE attribute length
net: Check for presence of IFLA_AF_SPEC
bridge: Add missing policy entry for IFLA_BRPORT_FAST_LEAVE
bridge: Sanitize IFLA_EXT_MASK for AF_BRIDGE:RTM_GETLINK

 drivers/net/ethernet/emulex/benet/be_main.c   |  5 +++++
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |  5 +++++
 net/bridge/br_netlink.c                       |  1 +
 net/core/rtnetlink.c                          | 23 ++++++++++++++++++-----
 4 files changed, 29 insertions(+), 5 deletions(-)
Signature · 1 line
1.9.3