Skip to content

package.bbclass: Do fixups even when FILES_foo is set

Peter Seebach openembedded-core 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1package.bbclass: do variable fixups even when FILES was setmeta/classes/package.bbclass+10 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] package.bbclass: Do fixups even when FILES_foo is set

There's some fixups for things like adding extra_depends to RDEPENDS which ended up in the "if not oldfiles" clause of a test against a setting for FILES_foo, but which I think should probably be done either way. The one that specifically affected us is that in some code for using a prebuilt toolchain, we set FILES_packagename from a manifest, which resulted in FILES_glibc-gconv-localename being set, which meant that RDEPENDS wasn't getting "glibc-gconv" appended for any of the glibc-gconv-localename packages, because the processing of extra_depends was conditional.

Two of these variables (summary and description) looked like things where the assumption might have been that you'd define SUMMARY_foo and DESCRIPTION_foo if you were defining FILES_foo, so I've also made those settings conditional on there not being an existing setting.

I ran builds of core-image-sato with and without this change, and looked at build history. 26 packages changed, but 23 were changes to PKGSIZE and nothing else.

The other three changes:

gst-plugins-good-gconfelements-dev has changes to RRECCOMMENDS, adding gst-plugins-good-dev, and gst-plugins-good-gconfelements has changes to RDEPENDS, adding gst-plugins-good. Both of these look reasonable to me.

perl-module-cpan has a change to RDEPENDS, adding perl. I think that's also reasonable.

So I don't think this breaks anything.

The following changes since commit 219e793907406eabf632e784e3a11ab9acb77cfb:

qemu/libc-package: Fix qemu option handling (2014-12-05 17:59:42 +0000)

are available in the git repository at:
git://git.yoctoproject.org/poky-contrib seebs/package_files
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/package_files

Peter Seebach (1):
package.bbclass: do variable fixups even when FILES was set

 meta/classes/package.bbclass |   18 ++++++++++--------
 1 files changed, 10 insertions(+), 8 deletions(-)