Skip to content

tty/serial: at91: fix atmel_serial_probe(), dma_sync_* and the Hardware Handshaking support

Cyrille Pitchen linux-arm-kernel linux-serial lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tty/serial: at91: use correct type for dma_sync_*_for_cpu() and dma_sync_*_for_device()drivers/tty/serial/atmel_serial.c+3 -32 replies
2/5tty/serial: at91: enable peripheral clock before accessing I/O registersdrivers/tty/serial/atmel_serial.c+12 -01 reply
3/5tty/serial: at91: fix error handling in atmel_serial_probe()drivers/tty/serial/atmel_serial.c+3 -11 reply
4/5tty/serial: at91: fix RTS line management when hardware handshake is enableddrivers/tty/serial/atmel_serial.c+61 -301 reply
5/5tty/serial: at91: fix typo and indentationdrivers/tty/serial/atmel_serial.c+22 -181 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchNicolas Ferre
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] tty/serial: at91: fix atmel_serial_probe(), dma_sync_* and the Hardware Handshaking support

This series of patches fix many bugs:
- a wrong enum type was used when calling dma_sync_*_for_cpu() and dma_sync_*_for_device()
- IO accesses to registers were done in atmel_serial_probe() after the peripheral clock had been disabled.
- the -EDEFER error was not handled properly in atmel_serial_probe()
- the Hardware Handshaking mode could never be enabled to control the RTS line

The patches were made from the next-20141205 tag of the linux-next repository. They were tested on a SAMA5Dx FPGA platform.

Cyrille Pitchen (5):
tty/serial: at91: use correct type for dma_sync_*_for_cpu() and

    dma_sync_*_for_device()

tty/serial: at91: enable peripheral clock before accessing I/O
registers
tty/serial: at91: fix error handling in atmel_serial_probe() tty/serial: at91: fix RTS line management when hardware handshake is
enabled
tty/serial: at91: fix typo and indentation

 drivers/tty/serial/atmel_serial.c | 153 +++++++++++++++++++++++++-------------
 1 file changed, 101 insertions(+), 52 deletions(-)
Signature · 1 line
1.8.2.2