Skip to content

cpufreq: stats: cleanups

Viresh Kumar linux-pm 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 1 replyIn review
  2. v214 patches 24 repliesSuperseded
  3. v113 patches 7 repliesSuperseded

V1->V2 from the cover letter

- New patches:
cpufreq: stats: remove unused cpufreq_stats_attribute
cpufreq: stats: initialize 'cur_time' on its definition
cpufreq: stats: rename 'struct cpufreq_stats' objects as 'stats'
cpufreq: stats: drop unnecessary locking

- Patches dropped:
cpufreq: stats: replace spinlock with mutex
cpufreq: stats: Fix locking
cpufreq: stats: call cpufreq_stats_update() with locks held

- Logs improved
- don't return error values notifiers on missing policy/stats
- rename stats_data as stats and make it cpufreq_stats pointer instead of void *

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16cpufreq: stats: Improve module description stringdrivers/cpufreq/cpufreq_stats.c+1 -20 replies
2/16cpufreq: stats: return -EEXIST when stats are already allocateddrivers/cpufreq/cpufreq_stats.c+3 -10 replies
3/16cpufreq: stats: remove unused cpufreq_stats_attributedrivers/cpufreq/cpufreq_stats.c+0 -50 replies
4/16cpufreq: stats: initialize 'cur_time' on its definitiondrivers/cpufreq/cpufreq_stats.c+1 -20 replies
5/16cpufreq: stats: don't check for freq table while freeing statsdrivers/cpufreq/cpufreq_stats.c+1 -20 replies
6/16cpufreq: stats: pass 'stat' to cpufreq_stats_update()drivers/cpufreq/cpufreq_stats.c+4 -60 replies
7/16cpufreq: stats: get rid of per-cpu cpufreq_stats_tabledrivers/cpufreq/cpufreq_stats.c include/linux/cpufreq.h+28 -290 replies
7/16cpufreq: stats: get rid of per-cpu cpufreq_stats_tabledrivers/cpufreq/cpufreq_stats.c include/linux/cpufreq.h+32 -330 replies
8/16cpufreq: stats: rename 'struct cpufreq_stats' objects as 'stats'drivers/cpufreq/cpufreq_stats.c+51 -510 replies
9/16cpufreq: Remove (now) unused 'last_cpu' from struct cpufreq_policydrivers/cpufreq/cpufreq.c include/linux/cpufreq.h+0 -50 replies
10/16cpufreq: stats: drop 'cpu' field of struct cpufreq_statsdrivers/cpufreq/cpufreq_stats.c+0 -120 replies
11/16cpufreq: remove CPUFREQ_UPDATE_POLICY_CPU notificationsdrivers/cpufreq/cpufreq.c include/linux/cpufreq.h+2 -60 replies
12/16cpufreq: stats: create sysfs group once we are readydrivers/cpufreq/cpufreq_stats.c+25 -190 replies
13/16cpufreq: stats: time_in_state can't be NULL in cpufreq_stats_update()drivers/cpufreq/cpufreq_stats.c+1 -30 replies
14/16cpufreq: stats: don't update stats from show_trans_table()drivers/cpufreq/cpufreq_stats.c+0 -10 replies
15/16cpufreq: stats: don't update stats on false notifiersdrivers/cpufreq/cpufreq_stats.c+2 -20 replies
16/16cpufreq: stats: drop unnecessary lockingdrivers/cpufreq/cpufreq_stats.c+1 -50 replies

Reviews trailers per patch

12 of 17 patches have a Reviewed-by or Acked-by.

PatchPrarit Bhargava
1/16R-b
2/16R-b
3/16
4/16
5/16R-b
6/16R-b
7/16R-b R-b
7/16R-b R-b
8/16
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16
14/16R-b
15/16R-b
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 00/16] cpufreq: stats: cleanups

Hi Rafael,

This is V3 of the stats cleanup I sent earlier. Few things are improved based on the feedback received (mostly from you). Please see if it looks any better.

Pushed here:
git://git.linaro.org/people/viresh.kumar/linux.git cpufreq/stats/cleanups

V1->V2:
- New patches:
cpufreq: stats: remove unused cpufreq_stats_attribute
cpufreq: stats: initialize 'cur_time' on its definition
cpufreq: stats: rename 'struct cpufreq_stats' objects as 'stats'
cpufreq: stats: drop unnecessary locking

- Patches dropped:
cpufreq: stats: replace spinlock with mutex
cpufreq: stats: Fix locking
cpufreq: stats: call cpufreq_stats_update() with locks held

- Logs improved
- don't return error values notifiers on missing policy/stats
- rename stats_data as stats and make it cpufreq_stats pointer instead of void *

Viresh Kumar (16):
cpufreq: stats: Improve module description string
cpufreq: stats: return -EEXIST when stats are already allocated
cpufreq: stats: remove unused cpufreq_stats_attribute
cpufreq: stats: initialize 'cur_time' on its definition
cpufreq: stats: don't check for freq table while freeing stats
cpufreq: stats: pass 'stat' to cpufreq_stats_update()
cpufreq: stats: get rid of per-cpu cpufreq_stats_table
cpufreq: stats: rename 'struct cpufreq_stats' objects as 'stats'
cpufreq: Remove (now) unused 'last_cpu' from struct cpufreq_policy
cpufreq: stats: drop 'cpu' field of struct cpufreq_stats
cpufreq: remove CPUFREQ_UPDATE_POLICY_CPU notifications
cpufreq: stats: create sysfs group once we are ready
cpufreq: stats: time_in_state can't be NULL in cpufreq_stats_update()
cpufreq: stats: don't update stats from show_trans_table()
cpufreq: stats: don't update stats on false notifiers
cpufreq: stats: drop unnecessary locking

 drivers/cpufreq/cpufreq.c       |   6 --
 drivers/cpufreq/cpufreq_stats.c | 211 ++++++++++++++++++----------------------
 include/linux/cpufreq.h         |  10 +-
 3 files changed, 98 insertions(+), 129 deletions(-)
Signature · 1 line
2.2.0