Skip to content

RFC preparation for block layer simplification

Dongsu Park linux-fsdevel linux-pm linux-raid lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 RFC Latest7 patches 7 repliesIn review

Changes in v2 from the cover letter

- split up preparation patches from v1 into this separate series.
- In the patch 02, pass iov_iter by value to __bio_copy_iov(), and split into read/write variants, as suggested by Christoph Hellwig.
- minor changes like writing more commit messages etc.

[1] https://lkml.org/lkml/2014/12/22/128

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7block: replace sg_iovec with iov_iterblock/bio.c block/blk-map.c block/scsi_ioctl.c +3 more+90 -970 replies
2/7block: rewrite __bio_copy_iov()block/bio.c+75 -384 replies
3/7block: refactor iov_count_pages() from bio_{copy,map}_user_iov()block/bio.c include/linux/uio.h lib/iovec.c+38 -371 reply
4/7block: refactor bio_get_user_pages() from __bio_map_user_iov()block/bio.c include/linux/bio.h+70 -621 reply
5/7md/raid10: make sync_request_write() call bio_copy_data()drivers/md/raid10.c+5 -150 replies
6/7fs: make _submit_bh consistent with generic bio chainingfs/buffer.c+2 -20 replies
7/7PM: submit bio in a sane way in cases without bio_chainkernel/power/block_io.c+18 -51 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC PATCH v2 0/7] preparation for block layer simplification

This is a preparation series for simplifying block layer based on immutable biovecs, a spin off of the v1 of simplifying patchset. [1] The original goal of simplifying block layer was actually making generic_make_request() accept arbitrarily sized bios, and pushing the splitting down to the underlying drivers.

This patchset aims at cleaning up several parts that are independent of core changes in the block layer. Doing that, it could be possible to change block layer relatively easily without keeping up with many patches.

- Patches 01-04/07 do refactoring to make the block layer use the new iov_iter interface.
- Patch 05/07 does refactoring and cleanup in MD-RAID10.
- Patch 06/07 changes a way of refcounting in fs/buffer.c, to be consistent with immutable biovecs API.
- Patch 07/07 makes bio submission in kernel/power in a sane way.

Patches are against 3.19-rc4. These are also available in my git repo at:

https://github.com/dongsupark/linux.git block-prep-simplify

This patchset should be first applied prior to upcoming patchsets such as "simplify block layer based on immutable biovecs." This patchset itself should not bring any regression to end-users.

Comments are welcome.
Dongsu

Changes in v2:
- split up preparation patches from v1 into this separate series.
- In the patch 02, pass iov_iter by value to __bio_copy_iov(), and split into read/write variants, as suggested by Christoph Hellwig.
- minor changes like writing more commit messages etc.

[1] https://lkml.org/lkml/2014/12/22/128

Dongsu Park (1):
block: rewrite __bio_copy_iov()

Kent Overstreet (6):
block: replace sg_iovec with iov_iter
block: refactor iov_count_pages() from bio_{copy,map}_user_iov()
block: refactor bio_get_user_pages() from __bio_map_user_iov() md/raid10: make sync_request_write() call bio_copy_data()
fs: make _submit_bh consistent with generic bio chaining
PM: submit bio in a sane way in cases without bio_chain

 block/bio.c             | 330 +++++++++++++++++++++++++-----------------------
 block/blk-map.c         |  27 ++--
 block/scsi_ioctl.c      |  19 +--
 drivers/md/raid10.c     |  20 +--
 drivers/scsi/sg.c       |  15 +--
 fs/buffer.c             |   4 +-
 include/linux/bio.h     |  10 +-
 include/linux/blkdev.h  |   4 +-
 include/linux/uio.h     |   2 +
 kernel/power/block_io.c |  23 +++-
 lib/iovec.c             |  30 +++++
 11 files changed, 263 insertions(+), 221 deletions(-)
Signature · 1 line
2.1.0