Skip to content

slub: make dead caches discard free slabs immediately

Vladimir Davydov linux-mm lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 22 repliesIn review
  2. v13 patches 20 repliesSuperseded

Changes in v2 from the cover letter

- address Christoph's concerns regarding kmem_cache_shrink
- fix race between put_cpu_partial reading ->cpu_partial and kmem_cache_shrink updating it as proposed by Joonsoo

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3slub: never fail to shrink cachemm/slub.c+30 -2716 replies
2/3slub: fix kmem_cache_shrink return valuemm/slub.c+5 -13 replies
3/3slub: make dead caches discard free slabs immediatelymm/slab.c mm/slab.h mm/slab_common.c +2 more+43 -113 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchChristoph LameterPekka Enberg
1/3A-b A-b
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH -mm v2 0/3] slub: make dead caches discard free slabs immediately

Hi,

The kmem extension of the memory cgroup is almost usable now. There is, in fact, the only serious issue left: per memcg kmem caches may pin the owner cgroup for indefinitely long. This is, because a slab cache may keep empty slab pages in its private structures to optimize performance, while we take a css reference per each charged kmem page.

The issue is only relevant to SLUB, because SLAB periodically reaps empty slabs. This patch set fixes this issue for SLUB. For details, please see patch 3.

Changes in v2:
- address Christoph's concerns regarding kmem_cache_shrink
- fix race between put_cpu_partial reading ->cpu_partial and kmem_cache_shrink updating it as proposed by Joonsoo

v1: https://lkml.org/lkml/2015/1/26/317

Thanks,

Vladimir Davydov (3):
slub: never fail to shrink cache
slub: fix kmem_cache_shrink return value
slub: make dead caches discard free slabs immediately

 mm/slab.c        |    4 +--
 mm/slab.h        |    2 +-
 mm/slab_common.c |   15 +++++++--
 mm/slob.c        |    2 +-
 mm/slub.c        |   94 +++++++++++++++++++++++++++++++++++-------------------
 5 files changed, 78 insertions(+), 39 deletions(-)
Signature · 7 lines
1.7.10.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>