Skip to content

rhashtable fixes

Thomas Graf netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 9 repliesIn review
  2. v16 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- Rebased on top of Herbert Xu's iterator code
- Fixed last remaining race that remained. Special thanks to Daniel Borkmann for assistance while debugging.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6rhashtable: key_hashfn() must return full hash valuelib/rhashtable.c+1 -70 replies
2/6rhashtable: Use a single bucket lock for sibling bucketslib/rhashtable.c+69 -1011 reply
3/6rhashtable: Wait for RCU readers after final unzip worklib/rhashtable.c+2 -00 replies
4/6rhashtable: Dump bucket tables on locking violation under PROVE_LOCKINGlib/rhashtable.c+75 -240 replies
5/6rhashtable: Add more lock verificationlib/rhashtable.c+8 -20 replies
6/6rhashtable: Avoid bucket cross reference after removallib/rhashtable.c+17 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH 0/6 v2 net-next] rhashtable fixes

This series fixes all remaining known issues with rhashtable that have been reported. In particular the race condition reported by Ying Xue.

---
Dave/Herbert: I'm posting this now as it fixes real issues. I'm fine with taking Herbert's rehash patches instead if they resolve all the reported issues as well.

v2:
- Rebased on top of Herbert Xu's iterator code
- Fixed last remaining race that remained. Special thanks to Daniel Borkmann for assistance while debugging.

Thomas Graf (6):
rhashtable: key_hashfn() must return full hash value
rhashtable: Use a single bucket lock for sibling buckets
rhashtable: Wait for RCU readers after final unzip work
rhashtable: Dump bucket tables on locking violation under
PROVE_LOCKING
rhashtable: Add more lock verification
rhashtable: Avoid bucket cross reference after removal

 lib/rhashtable.c | 305 ++++++++++++++++++++++++++++++-------------------------
 1 file changed, 167 insertions(+), 138 deletions(-)