Skip to content

OPT_{FILENAME,PATH}

Michael J Gruber git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4parse-options: introduce OPT_PATHDocumentation/technical/api-parse-options.txt parse-options.h+7 -03 replies
2/4option-strings: use OPT_FILENAMEarchive.c builtin/archive.c builtin/blame.c +4 more+9 -93 replies
3/4option-strings: use OPT_PATHbuiltin/clone.c builtin/init-db.c+4 -43 replies
4/4checkout: --to requires directorybuiltin/checkout.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] OPT_{FILENAME,PATH}

Here's a "mini-war" on file-type arguments being specified as OPT_STRING (in order to repent for doing so myself).

1/4 introduces OPT_PATH which is like OPT_FILENAME, but takes an additional argument which names the option argument.
2/4 converts OPT_STRING to OPT_FILENAME where it makes sense 3/4 converts OPT_STRING to OPT_PATH where it makes sense
4/4 converts OPT_FILENAME to OPT_PATH for "checkout --to"

1/4, 2/4 should apply on top of origin/next independently. 3/4 needs 1/4.
4/4 needs 1/4 and is on top of nd/multiple-worktrees.

Michael J Gruber (4):
parse-options: introduce OPT_PATH
option-strings: use OPT_FILENAME
option-strings: use OPT_PATH
checkout: --to requires directory

 Documentation/technical/api-parse-options.txt | 5 +++++
 archive.c                                     | 2 +-
 builtin/archive.c                             | 2 +-
 builtin/blame.c                               | 4 ++--
 builtin/checkout.c                            | 2 +-
 builtin/clone.c                               | 4 ++--
 builtin/config.c                              | 2 +-
 builtin/fast-export.c                         | 4 ++--
 builtin/hash-object.c                         | 2 +-
 builtin/init-db.c                             | 4 ++--
 builtin/ls-files.c                            | 2 +-
 parse-options.h                               | 2 ++
 12 files changed, 21 insertions(+), 14 deletions(-)
Signature · 1 line
2.3.0.296.g32c87e1