Skip to content

rhashtable updates

Daniel Borkmann netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 24 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2rhashtable: unconditionally grow when max_shift is not specifiedlib/rhashtable.c lib/test_rhashtable.c+1 -34 replies
2/2rhashtable: remove indirection for grow/shrink decision functionsinclude/linux/rhashtable.h lib/rhashtable.c lib/test_rhashtable.c +3 more+18 -5819 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchThomas Graf
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/2] rhashtable updates

As discussed, I'm sending out rhashtable fixups for -net.

I have a couple of more patches I was working on last week pending, i.e. to get rid of ht->nelems and ht->shift atomic operations which speed-up pure insertions/deletions, e.g. on my laptop I have 2 threads, inserting 7M entries each, that will reduce insertion time from ~1,450 ms to 865 ms (performance should even be better after removing the grow/shrink indirections). I guess that however is rather something for net-next.

Thanks,
Daniel

Daniel Borkmann (2):
rhashtable: unconditionally grow when max_shift is not specified
rhashtable: remove indirection for grow/shrink decision functions

 include/linux/rhashtable.h | 13 -----------
 lib/rhashtable.c           | 58 ++++++++++++++--------------------------------
 lib/test_rhashtable.c      |  3 +--
 net/netfilter/nft_hash.c   |  2 --
 net/netlink/af_netlink.c   |  2 --
 net/tipc/socket.c          |  2 --
 6 files changed, 19 insertions(+), 61 deletions(-)
Signature · 1 line
1.9.3