Skip to content

x86/asm changes for 4.1 for review

Andy Lutomirski lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16x86: open-code register save/restore in trace_hardirqs thunksarch/x86/lib/thunk_64.S+42 -40 replies
2/16x86: introduce push/pop macros which generate CFI_REL_OFFSET and CFI_RESTOREarch/x86/include/asm/calling.h arch/x86/include/asm/dwarf2.h arch/x86/kernel/entry_32.S +6 more+141 -1960 replies
3/16x86: entry_64.S: fix wrong symbolic constant usage: R11->ARGOFFSETarch/x86/kernel/entry_64.S+3 -30 replies
4/16x86: entry_64.S: always allocate complete "struct pt_regs"arch/x86/ia32/ia32entry.S arch/x86/include/asm/calling.h arch/x86/include/asm/irqflags.h +2 more+210 -2602 replies
5/16x86: entry_64.S: fix comments. No code changesarch/x86/include/asm/ptrace.h arch/x86/include/uapi/asm/ptrace-abi.h arch/x86/include/uapi/asm/ptrace.h +1 more+43 -160 replies
6/16x86: code shrink in paranoid_exitarch/x86/kernel/entry_64.S+4 -60 replies
7/16x86: mass removal of ARGOFFSET. No code changesarch/x86/ia32/ia32entry.S arch/x86/include/asm/calling.h arch/x86/kernel/entry_64.S+114 -1160 replies
8/16x86, entry: Remove int_check_syscall_exit_workarch/x86/kernel/entry_64.S+0 -10 replies
9/16x86: add comments about various syscall instructions, no code changesarch/x86/ia32/ia32entry.S arch/x86/kernel/entry_64.S+102 -630 replies
10/16x86: entry_64.S: move save_paranoid and ret_from_fork closer to their usersarch/x86/kernel/entry_64.S+53 -530 replies
11/16x86: entry_64.S: rename save_paranoid to paranoid_entry, no code changesarch/x86/kernel/entry_64.S+36 -320 replies
12/16x86: ia32entry.S: fold IA32_ARG_FIXUP macro into its callersarch/x86/ia32/ia32entry.S+18 -140 replies
13/16x86: entry_64.S: use more understandable constantsarch/x86/include/asm/calling.h arch/x86/kernel/entry_64.S+18 -120 replies
14/16x86: ia32entry.S: use more understandable constantarch/x86/ia32/ia32entry.S+1 -10 replies
15/16x86: entry.S: simplify optimistic SYSRETarch/x86/include/asm/calling.h arch/x86/kernel/entry_64.S+6 -31 reply
16/16x86_64, entry: Remove a bogus ret_from_fork optimizationarch/x86/kernel/entry_64.S+8 -50 replies

Reviews trailers per patch

1 of 16 patches has a Reviewed-by or Acked-by.

PatchIngo Molnar
1/16
2/16
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/16] x86/asm changes for 4.1 for review

Hi all-

After much handwringing, painful review, and curation, here's round 1 of the x86/asm changes. (This is not intended to imply that there will or will not be a round 2.)

For ease of review for git users:

The following changes since commit 7453311d68f16a5c587c3cbf19563c9a4fbbd41a:

Merge branch 'x86-asm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2015-02-09 17:16:44 -0800)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git

for you to fetch changes up to 4710be56d76ef994ddf59087aad98c000fbab9a4:

x86_64, entry: Remove a bogus ret_from_fork optimization (2015-02-26 07:09:36 -0800)

Ingo, if you like these, feel free to pull. I will try to review the scary change *again* this evening if I have time. In the mean time, these are queued as is for -next. I will remove them from my -next branch if they turn out to be buggy or if they end up in -tip in any form.

Andy Lutomirski (2):
x86, entry: Remove int_check_syscall_exit_work x86_64, entry: Remove a bogus ret_from_fork optimization

Denys Vlasenko (14):
x86: open-code register save/restore in trace_hardirqs thunks
x86: introduce push/pop macros which generate CFI_REL_OFFSET and
CFI_RESTORE
x86: entry_64.S: fix wrong symbolic constant usage: R11->ARGOFFSET
x86: entry_64.S: always allocate complete "struct pt_regs"
x86: entry_64.S: fix comments. No code changes
x86: code shrink in paranoid_exit
x86: mass removal of ARGOFFSET. No code changes
x86: add comments about various syscall instructions, no code changes
x86: entry_64.S: move save_paranoid and ret_from_fork closer to their
users
x86: entry_64.S: rename save_paranoid to paranoid_entry, no code
changes
x86: ia32entry.S: fold IA32_ARG_FIXUP macro into its callers
x86: entry_64.S: use more understandable constants
x86: ia32entry.S: use more understandable constant
x86: entry.S: simplify optimistic SYSRET

 arch/x86/ia32/ia32entry.S              | 342 ++++++++++++----------
 arch/x86/include/asm/calling.h         | 267 ++++++++---------
 arch/x86/include/asm/dwarf2.h          |  24 ++
 arch/x86/include/asm/irqflags.h        |   4 +-
 arch/x86/include/asm/ptrace.h          |  13 +-
 arch/x86/include/uapi/asm/ptrace-abi.h |  16 +-
 arch/x86/include/uapi/asm/ptrace.h     |  13 +-
 arch/x86/kernel/entry_32.S             |  21 +-
 arch/x86/kernel/entry_64.S             | 510 ++++++++++++++++-----------------
 arch/x86/lib/atomic64_cx8_32.S         |  50 ++--
 arch/x86/lib/checksum_32.S             |  60 ++--
 arch/x86/lib/msr-reg.S                 |  24 +-
 arch/x86/lib/rwsem.S                   |  44 ++-
 arch/x86/lib/thunk_32.S                |  18 +-
 arch/x86/lib/thunk_64.S                |  28 +-
 15 files changed, 724 insertions(+), 710 deletions(-)
Signature · 1 line
2.1.0