Skip to content

remove unused variables

Aya Mahfouz outreachy 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24staging: wlan-ng: remove unused variabledrivers/staging/wlan-ng/prism2sta.c+1 -40 replies
2/24staging: wlan-ng: remove unused variabledrivers/staging/wlan-ng/prism2mib.c+2 -90 replies
3/24staging: vt6655: remove unused variabledrivers/staging/vt6655/rxtx.c+1 -50 replies
4/24staging: rtl8188eu: os_dep: remove unused variabledrivers/staging/rtl8188eu/os_dep/usb_ops_linux.c+3 -131 reply
5/24staging: rtl8188eu: os_dep: remove unused variabledrivers/staging/rtl8188eu/os_dep/ioctl_linux.c+1 -30 replies
6/24staging: lustre: ptlrpc: remove unused variabledrivers/staging/lustre/lustre/ptlrpc/nrs.c+1 -40 replies
7/24staging: lustre: osc: remove unused variabledrivers/staging/lustre/lustre/osc/lproc_osc.c+1 -40 replies
8/24staging: lustre: obdecho: remove unused variabledrivers/staging/lustre/lustre/obdecho/echo_client.c+1 -40 replies
9/24staging: lustre: obdclass: remove unused variabledrivers/staging/lustre/lustre/obdclass/lu_object.c+1 -50 replies
10/24staging: lustre: obdclass: remove unused variabledrivers/staging/lustre/lustre/obdclass/dt_object.c+1 -40 replies
11/24staging: lustre: mgc: remove unused variabledrivers/staging/lustre/lustre/mgc/mgc_request.c+1 -40 replies
12/24staging: lustre: mdc: remove unused variabledrivers/staging/lustre/lustre/mdc/mdc_request.c+1 -30 replies
13/24staging: lustre: mdc: remove unused variabledrivers/staging/lustre/lustre/mdc/mdc_locks.c+1 -31 reply
14/24staging: lustre: lov: remove unused variabledrivers/staging/lustre/lustre/lov/lov_obd.c+2 -32 replies
15/24staging: lustre: lmv: remove unused variablesdrivers/staging/lustre/lustre/lmv/lmv_obd.c+2 -61 reply
16/24staging: lustre: llite: remove unused variabledrivers/staging/lustre/lustre/llite/vvp_io.c+1 -41 reply
17/24staging: lustre: llite: remove unused variabledrivers/staging/lustre/lustre/llite/lproc_llite.c+1 -40 replies
18/24staging: lustre: llite: remove unused variabledrivers/staging/lustre/lustre/llite/file.c+1 -32 replies
19/24staging: lustre: llite: remove unused variabledrivers/staging/lustre/lustre/llite/dcache.c+1 -40 replies
20/24staging: iio: meter: remove unused variabledrivers/staging/iio/meter/ade7759.c+1 -40 replies
21/24staging: iio: meter: remove unused variablesdrivers/staging/iio/meter/ade7758_core.c+2 -83 replies
22/24staging: iio: light: remove unused variabledrivers/staging/iio/light/tsl2583.c+1 -30 replies
23/24staging: fbtft: remove unused variabledrivers/staging/fbtft/fbtft-core.c+1 -30 replies
24/24staging: dgap: remove unused variabledrivers/staging/dgap/dgap.c+1 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/24] remove unused variables

This patchset is concerned with removing variables that were used only once to store the value of a function and then return it. The following coccinelle script was used to discover the pattern and resolve it:

@@
identifier len,f;
@@

-int len;
... when != len
when strict
-len =
+return

        f(...);

-return len;

Aya Mahfouz (24):
staging: wlan-ng: remove unused variable
staging: wlan-ng: remove unused variable
staging: vt6655: remove unused variable
staging: rtl8188eu: os_dep: remove unused variable
staging: rtl8188eu: os_dep: remove unused variable
staging: lustre: ptlrpc: remove unused variable
staging: lustre: osc: remove unused variable
staging: lustre: obdecho: remove unused variable
staging: lustre: obdclass: remove unused variable
staging: lustre: obdclass: remove unused variable
staging: lustre: mgc: remove unused variable
staging: wlan-ng: remove unused variable
staging: lustre: mdc: remove unused variable
staging: lustre: lov: remove unused variable
staging: lustre: lmv: remove unused variables
staging: lustre: llite: remove unused variable
staging: lustre: llite: remove unused variable
staging: lustre: llite: remove unused variable
staging: lustre: llite: remove unused variable
staging: iio: meter: remove unused variable
staging: iio: meter: remove unused variables
staging: iio: light: remove unused variable
staging: fbtft: remove unused variable
staging: dgap: remove unused variable

 drivers/staging/dgap/dgap.c                         |  5 +----
 drivers/staging/fbtft/fbtft-core.c                  |  4 +---
 drivers/staging/iio/light/tsl2583.c                 |  4 +---
 drivers/staging/iio/meter/ade7758_core.c            | 10 ++--------
 drivers/staging/iio/meter/ade7759.c                 |  5 +----
 drivers/staging/lustre/lustre/llite/dcache.c        |  5 +----
 drivers/staging/lustre/lustre/llite/file.c          |  4 +---
 drivers/staging/lustre/lustre/llite/lproc_llite.c   |  5 +----
 drivers/staging/lustre/lustre/llite/vvp_io.c        |  5 +----
 drivers/staging/lustre/lustre/lmv/lmv_obd.c         |  8 ++------
 drivers/staging/lustre/lustre/lov/lov_obd.c         |  5 ++---
 drivers/staging/lustre/lustre/mdc/mdc_locks.c       |  4 +---
 drivers/staging/lustre/lustre/mdc/mdc_request.c     |  4 +---
 drivers/staging/lustre/lustre/mgc/mgc_request.c     |  5 +----
 drivers/staging/lustre/lustre/obdclass/dt_object.c  |  5 +----
 drivers/staging/lustre/lustre/obdclass/lu_object.c  |  6 +-----
 drivers/staging/lustre/lustre/obdecho/echo_client.c |  5 +----
 drivers/staging/lustre/lustre/osc/lproc_osc.c       |  5 +----
 drivers/staging/lustre/lustre/ptlrpc/nrs.c          |  5 +----
 drivers/staging/rtl8188eu/os_dep/ioctl_linux.c      |  4 +---
 drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c    | 16 +++-------------
 drivers/staging/vt6655/rxtx.c                       |  6 +-----
 drivers/staging/wlan-ng/prism2mib.c                 | 11 ++---------
 drivers/staging/wlan-ng/prism2sta.c                 |  5 +----
 24 files changed, 30 insertions(+), 111 deletions(-)
Signature · 6 lines
1.9.3


-- 
Kind Regards,
Aya Saif El-yazal Mahfouz