Skip to content

drm: constify all helper_private/func pointers

Jani Nikula dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm: constify all struct drm_encoder_helper_funcs pointersdrivers/gpu/drm/drm_atomic_helper.c drivers/gpu/drm/drm_crtc_helper.c drivers/gpu/drm/gma500/cdv_intel_hdmi.c +12 more+33 -331 reply
2/4drm: constify all struct drm_connector_helper_funcs pointersdrivers/gpu/drm/drm_atomic_helper.c drivers/gpu/drm/drm_crtc_helper.c drivers/gpu/drm/drm_fb_helper.c +3 more+9 -90 replies
3/4drm: constify all struct drm_crtc_helper_funcs pointersdrivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c drivers/gpu/drm/drm_atomic_helper.c drivers/gpu/drm/drm_crtc_helper.c +12 more+33 -330 replies
4/4drm: make encoder/connector/crtc helper_private a const pointerinclude/drm/drm_crtc.h include/drm/drm_crtc_helper.h+6 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] drm: constify all helper_private/func pointers
Quoted 2 lines · On Tue, 10 Mar 2015, [email protected] wrote:

Make the helper function pointer structs const to make it clear they should not be modified.

So why not fix this once and for all? See the following patches.

This was quick cocci, can be split by driver too if so desired.

BR,
Jani.

Jani Nikula (4):
drm: constify all struct drm_encoder_helper_funcs pointers
drm: constify all struct drm_connector_helper_funcs pointers
drm: constify all struct drm_crtc_helper_funcs pointers
drm: make encoder/connector/crtc helper_private a const pointer

 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c    |  4 ++--
 drivers/gpu/drm/drm_atomic_helper.c             | 24 ++++++++++++------------
 drivers/gpu/drm/drm_crtc_helper.c               | 24 ++++++++++++------------
 drivers/gpu/drm/drm_fb_helper.c                 |  8 ++++----
 drivers/gpu/drm/drm_plane_helper.c              |  2 +-
 drivers/gpu/drm/drm_probe_helper.c              |  2 +-
 drivers/gpu/drm/exynos/exynos_hdmi.c            |  2 +-
 drivers/gpu/drm/gma500/cdv_intel_display.c      |  2 +-
 drivers/gpu/drm/gma500/cdv_intel_hdmi.c         |  2 +-
 drivers/gpu/drm/gma500/cdv_intel_lvds.c         |  2 +-
 drivers/gpu/drm/gma500/gma_display.c            | 10 +++++-----
 drivers/gpu/drm/gma500/mdfld_dsi_output.c       |  2 +-
 drivers/gpu/drm/gma500/mdfld_intel_display.c    |  2 +-
 drivers/gpu/drm/gma500/oaktrail_crtc.c          |  2 +-
 drivers/gpu/drm/gma500/oaktrail_hdmi.c          |  2 +-
 drivers/gpu/drm/gma500/psb_intel_display.c      |  2 +-
 drivers/gpu/drm/gma500/psb_intel_lvds.c         |  2 +-
 drivers/gpu/drm/mgag200/mgag200_mode.c          |  2 +-
 drivers/gpu/drm/nouveau/dispnv04/crtc.c         |  4 ++--
 drivers/gpu/drm/nouveau/dispnv04/dac.c          |  6 +++---
 drivers/gpu/drm/nouveau/dispnv04/dfp.c          |  6 +++---
 drivers/gpu/drm/nouveau/dispnv04/disp.c         |  6 +++---
 drivers/gpu/drm/nouveau/dispnv04/tvnv04.c       |  4 ++--
 drivers/gpu/drm/nouveau/dispnv04/tvnv17.c       |  4 ++--
 drivers/gpu/drm/nouveau/nouveau_connector.c     |  4 ++--
 drivers/gpu/drm/qxl/qxl_drv.c                   |  2 +-
 drivers/gpu/drm/radeon/radeon_connectors.c      | 16 ++++++++--------
 drivers/gpu/drm/radeon/radeon_legacy_encoders.c |  2 +-
 include/drm/drm_crtc.h                          |  6 +++---
 include/drm/drm_crtc_helper.h                   |  6 +++---
 30 files changed, 81 insertions(+), 81 deletions(-)
Signature · 6 lines
2.1.4

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel