Skip to content

x86_64: Sigcontext improvements

Andy Lutomirski lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest2 patches 32 repliesIn review

Changes from v1 from the cover letter

- Add the __USER_DS fix, caught by my sigreturn test.
- Re-tested locally.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2x86_64,signal: Fix SS handling for signals delivered to 64-bit programsarch/x86/include/asm/sigcontext.h arch/x86/include/uapi/asm/sigcontext.h arch/x86/kernel/signal.c+15 -1131 replies
2/2x86_64,signal: Remove 'fs' and 'gs' from sigcontextarch/x86/include/asm/sigcontext.h arch/x86/include/uapi/asm/sigcontext.h arch/x86/kernel/signal.c+21 -60 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchOleg NesterovBorislav Petkov
SeriesR-b
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] x86_64: Sigcontext improvements

Patch 1 is IMO a bug fix.

Patch 2 is a cleanup and avoids some confusion. It's also sort of an API break (no ABI change) because it removes a struct field. But that struct field has never done anything at all as far as I can tell.

AFAICT this series got bogged down in discussion about patch 2 last time. I'm only including patch 2 for completeness here -- patch 1 is IMO far more useful, and I'm fine with patch 1 being merged and tabling patch 2 again.

Changes from v1:
- Add the __USER_DS fix, caught by my sigreturn test.
- Re-tested locally.

Changes from 2:
- Fixed comment style in patch 1.
- Added a better comment in patch 2.

Andy Lutomirski (2):
x86_64,signal: Fix SS handling for signals delivered to 64-bit
programs
x86_64,signal: Remove 'fs' and 'gs' from sigcontext

 arch/x86/include/asm/sigcontext.h      |  6 +++---
 arch/x86/include/uapi/asm/sigcontext.h | 21 ++++++++++++++++++---
 arch/x86/kernel/signal.c               | 26 +++++++++++++++-----------
 3 files changed, 36 insertions(+), 17 deletions(-)
Signature · 1 line
2.3.0