Staging: iio/frequency: Fix style issues
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 6 repliesIn review
- v16 patches 7 repliesSuperseded
Changes in v2 from the cover letter
[PATCH v2 3/6]
- add BIT() macro implementation in ad9834.h for macros AD9834_REG_FREQ and AD9834_REG_PHASE involving phase and frequency registers. Checked against the datasheet.
[PATCH v2 5/6]
- make the commit message more clear
- align parameters in ad9834_show_out[0|1]_wavetype_available() functions, also.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | Staging: iio: Remove space after type castdrivers/ drivers/ | +6 | 1 reply | |
| 2/6 | Staging: iio: Remove explicit comparison to NULLdrivers/ drivers/ | +2 | 1 reply | |
| 3/6 | Staging: iio: Prefer using the BIT macrodrivers/ drivers/ drivers/ +1 more | +27 | 1 reply | |
| 4/6 | Staging: iio: Do not use multiple blank linesdrivers/ drivers/ | +0 | 1 reply | |
| 5/6 | Staging: iio: Alignment should match open parenthesisdrivers/ | +16 | 1 reply | |
| 6/6 | Staging: iio: Use braces on all arms of if statementdrivers/ | +2 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Daniel Baluta |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/6] Staging: iio/frequency: Fix style issues
This patchset involves removing style issues in iio/frequency and cleaning up as suggested by checkpatch.pl.
Changes in v2:
[PATCH v2 3/6]
- add BIT() macro implementation in ad9834.h for macros AD9834_REG_FREQ and AD9834_REG_PHASE involving phase and frequency registers. Checked against the datasheet.
[PATCH v2 5/6]
- make the commit message more clear
- align parameters in ad9834_show_out[0|1]_wavetype_available() functions, also.
Mention: Regarding the indentation, I applied the patches on a separate test branch and they aligned well. It shows up twisted only in the patch format for an unknown reason.
Cristina Opriceana (6):
Staging: iio: Remove space after type cast
Staging: iio: Remove explicit comparison to NULL
Staging: iio: Prefer using the BIT macro
Staging: iio: Do not use multiple blank lines
Staging: iio: Alignment should match open parenthesis
Staging: iio: Use braces on all arms of if statement
drivers/staging/iio/frequency/ad9832.c | 10 ++++---- drivers/staging/iio/frequency/ad9832.h | 12 ++++----- drivers/staging/iio/frequency/ad9834.c | 45 +++++++++++++++++----------------- drivers/staging/iio/frequency/ad9834.h | 37 ++++++++++++++-------------- 4 files changed, 52 insertions(+), 52 deletions(-)
Signature · 1 line
1.9.1