Skip to content

Replace memcpy with ether_addr_copy and fix checkpatch warning

Darshana Padmadas outreachy 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyIn review
  2. v2 posting 2/25 patches 2 repliesSuperseded
  3. v2 posting 1/22 of 5 patches 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches4 repliesSuperseded

Changes in v3 from the cover letter

- Abandoned patch 5/5 in v2 as it caused warnings during build.
- Edited commit message in patch 3 to include structure layout.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Staging: rtl8192e: Replace memcpy with ether_addr_copydrivers/staging/rtl8192e/rtl819x_BAProc.c+3 -21 reply
2/4Staging: rtl8192e: Use ether_addr_copy instead of memcpydrivers/staging/rtl8192e/rtllib_crypt_tkip.c+6 -60 replies
3/4Staging: rtl8192e: Use ether_addr_copy replacing memcpydrivers/staging/rtl8192e/rtllib_softmac.c+6 -60 replies
4/4Staging: rtl8192e: Use ether_addr_copy for aligned addressesdrivers/staging/rtl8192e/rtllib_tx.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/4] Replace memcpy with ether_addr_copy and fix checkpatch warning

This patch set replaces memcpy with ether_addr_copy if the addresses of the structures are aligned. Structure layout is shown by using the Pahole tool.

This patch set fixes the following warning reported by checkpatch:
WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)

Darshana Padmadas (4):
Changes in v3:
- Abandoned patch 5/5 in v2 as it caused warnings during build.
- Edited commit message in patch 3 to include structure layout.

Staging: rtl8192e: Replace memcpy with ether_addr_copy
Staging: rtl8192e: Use ether_addr_copy instead of memcpy
Staging: rtl8192e: Use ether_addr_copy replacing memcpy
Staging: rtl8192e: Use ether_addr_copy for aligned addresses

 drivers/staging/rtl8192e/rtl819x_BAProc.c    |  5 +++--
 drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 12 ++++++------
 drivers/staging/rtl8192e/rtllib_softmac.c    | 12 ++++++------
 drivers/staging/rtl8192e/rtllib_tx.c         |  6 +++---
 4 files changed, 18 insertions(+), 17 deletions(-)
Signature · 1 line
1.9.1