Skip to content

Staging: speakup: Introduce helper macro module_spk_synth

Vaishali Thakkar outreachy 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest1 of 2 patches 0 repliesNew
  2. v31 of 2 patches 2 repliesSuperseded
  3. v21 of 2 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 of 2 patches0 repliesSuperseded

Changes in v4 from the cover letter

- Fix build warnings of v2

1 of 2 patches is in this archive. The cover letter announces 2.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/2Staging: speakup: Use module_spk_synthdrivers/staging/speakup/speakup_acntpc.c drivers/staging/speakup/speakup_acntsa.c drivers/staging/speakup/speakup_apollo.c +12 more+15 -1660 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] Staging: speakup: Introduce helper macro module_spk_synth

This patch-set adds new macro module_spk_synth for simple modules that contain a single spk_synth without any additional setup code then ends up being a block of duplicated boilerplate. Macro module_spk_synth replaces module_init()/module_exit() registrations with template functions. So, patch-set also handles all such cases where module_spk_synth can be used.

Changes since v1:
- Add blank line after defining module_spk_synth
Changes since v2:
- Avoid adding unnecessory comments
Changes since v3:
- Fix build warnings of v2

Vaishali Thakkar (2):
Staging: speakup: Add helper macro for spk_synth boilerplate
Staging: speakup: Use module_spk_synth

 drivers/staging/speakup/speakup_acntpc.c | 12 +-----------
 drivers/staging/speakup/speakup_acntsa.c | 12 +-----------
 drivers/staging/speakup/speakup_apollo.c | 12 +-----------
 drivers/staging/speakup/speakup_audptr.c | 12 +-----------
 drivers/staging/speakup/speakup_bns.c    | 12 +-----------
 drivers/staging/speakup/speakup_decext.c | 12 +-----------
 drivers/staging/speakup/speakup_decpc.c  | 12 +-----------
 drivers/staging/speakup/speakup_dectlk.c | 12 +-----------
 drivers/staging/speakup/speakup_dtlk.c   | 12 +-----------
 drivers/staging/speakup/speakup_dummy.c  | 12 +-----------
 drivers/staging/speakup/speakup_keypc.c  | 12 +-----------
 drivers/staging/speakup/speakup_ltlk.c   | 12 +-----------
 drivers/staging/speakup/speakup_soft.c   | 13 +------------
 drivers/staging/speakup/speakup_spkout.c | 12 +-----------
 drivers/staging/speakup/speakup_txprt.c  | 12 +-----------
 drivers/staging/speakup/spk_types.h      | 11 +++++++++++
 16 files changed, 26 insertions(+), 166 deletions(-)
Signature · 1 line
1.9.1