Skip to content

rhashtable updates on top of Herbert's work

Thomas Graf netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5rhashtable: Extend RCU read lock into rhashtable_insert_rehash()include/linux/rhashtable.h+1 -11 reply
2/5rhashtable: Use 'unsigned int' consistentlyinclude/linux/rhashtable.h lib/rhashtable.c+17 -150 replies
3/5rhashtable: Mark internal/private inline functions as suchinclude/linux/rhashtable.h+2 -00 replies
4/5rhashtable: Disable automatic shrinking by defaultinclude/linux/rhashtable.h lib/test_rhashtable.c net/netfilter/nft_hash.c +2 more+27 -115 replies
5/5rhashtable: Add rhashtable_free_and_destroy()include/linux/rhashtable.h lib/rhashtable.c net/netfilter/nft_hash.c+49 -300 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5 net-next] rhashtable updates on top of Herbert's work

Patch 1 is a bugfix for an RCU splash I encountered while testing. Patch 2 & 3 are pure cleanups. Patch 4 disables automatic shrinking by default as discussed in previous thread. Patch 5 removes some rhashtable internal knowledge from nft_hash and fixes another RCU splash.

I've pushed various rhashtable tests (Netlink, nft) together with a Makefile to a git tree [0] for easier stress testing.

[0] https://github.com/tgraf/rhashtable

Thomas Graf (5):
rhashtable: Extend RCU read lock into rhashtable_insert_rehash()
rhashtable: Use 'unsigned int' consistently
rhashtable: Mark internal/private inline functions as such
rhashtable: Disable automatic shrinking by default
rhashtable: Add rhashtable_free_and_destroy()

 include/linux/rhashtable.h | 50 +++++++++++++++++++++++-----------
 lib/rhashtable.c           | 67 +++++++++++++++++++++++++++++++++-------------
 lib/test_rhashtable.c      |  2 +-
 net/netfilter/nft_hash.c   | 27 ++++++-------------
 net/netlink/af_netlink.c   |  4 +--
 net/tipc/socket.c          |  3 ++-
 6 files changed, 96 insertions(+), 57 deletions(-)
Signature · 1 line
1.9.3