Skip to content

net/macb: fixes after big driver update

Nicolas Ferre linux-arm-kernel lkml netdev stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 3 repliesIn review
  2. v14 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- address Cyrille comment about exit condition of queue configuration loop
- add fixes for probe sequence related to clocks
- add ethtool register dump
- fix peripheral version test

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8net/macb: only probe queues once and use stored valuesdrivers/net/ethernet/cadence/macb.c drivers/net/ethernet/cadence/macb.h+4 -40 replies
2/8net/macb: add comment in macb_probe_queuesdrivers/net/ethernet/cadence/macb.c+6 -20 replies
3/8net/macb: fix capabilities configurationdrivers/net/ethernet/cadence/macb.c+18 -180 replies
4/8net/macb: trivial: correct wording for capsdrivers/net/ethernet/cadence/macb.c+2 -20 replies
5/8net/macb: fix probe sequence to setup clocks earlierdrivers/net/ethernet/cadence/macb.c drivers/net/ethernet/cadence/macb.h+104 -670 replies
6/8net/macb: add the user i/o to ethtool register dumpdrivers/net/ethernet/cadence/macb.c drivers/net/ethernet/cadence/macb.h+2 -20 replies
7/8net/macb: fix the peripheral version testdrivers/net/ethernet/cadence/macb.c+1 -11 reply
8/8net/macb: unify peripheral version testingdrivers/net/ethernet/cadence/macb.c drivers/net/ethernet/cadence/macb.h+7 -51 reply

Reviews trailers per patch

3 of 8 patches have a Reviewed-by or Acked-by.

PatchBoris BrezillonPunnaiah Choudary Kalluri
1/8A-b
2/8
3/8
4/8
5/8
6/8
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/8] net/macb: fixes after big driver update

The recent modifications to the macb driver lead to issues with the probe function code flow. Here are some attempt to fix them.
This time, some more issues are fixed related to the clock as reported by Boris Brezillon.

The series is written on top of net-next.

Changes in v2:
- address Cyrille comment about exit condition of queue configuration loop
- add fixes for probe sequence related to clocks
- add ethtool register dump
- fix peripheral version test

Nicolas Ferre (8):
net/macb: only probe queues once and use stored values net/macb: add comment in macb_probe_queues net/macb: fix capabilities configuration net/macb: trivial: correct wording for caps net/macb: fix probe sequence to setup clocks earlier net/macb: add the user i/o to ethtool register dump net/macb: fix the peripheral version test net/macb: unify peripheral version testing

 drivers/net/ethernet/cadence/macb.c | 207 +++++++++++++++++++++---------------
 drivers/net/ethernet/cadence/macb.h |  10 +-
 2 files changed, 130 insertions(+), 87 deletions(-)
Signature · 1 line
2.1.3