Skip to content

remove icc bus/bridge

Zhu Guihua qemu-devel 12 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest5 patches 10 repliesIn review
  2. v115 patches 5 repliesSuperseded
  3. v104 patches 3 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v9 posting 2/24 patches8 repliesSuperseded
v9 posting 1/24 patches4 repliesSuperseded
v8 posting 2/24 patches23 repliesSuperseded
v8 posting 1/24 patches1 replySuperseded
v73 patches4 repliesSuperseded
v64 patches16 repliesApplied
v54 patches3 repliesSuperseded
v4 posting 2/24 patches3 repliesSuperseded
v4 posting 1/24 patches0 repliesSuperseded

Changes in v12 from the cover letter

-move APIC MMIO mapping into x86_cpu_apic_realize() -change commit message in PATCH 4

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5apic: move APIC's MMIO region mapping into APIChw/i386/pc.c hw/intc/apic_common.c target-i386/cpu.c+15 -131 reply
2/5apic: use per CPU AS to map APIC MMIO for TCGtarget-i386/cpu.c+11 -24 replies
3/5x86: use new method to correct reset sequencehw/i386/pc.c+20 -01 reply
4/5cpu/apic: drop icc bus/bridgehw/i386/pc.c hw/i386/pc_piix.c hw/i386/pc_q35.c +4 more+14 -461 reply
5/5icc_bus: drop the unused filesdefault-configs/i386-softmmu.mak default-configs/x86_64-softmmu.mak hw/cpu/Makefile.objs +2 more+0 -2031 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchIgor Mammedov
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v12 thread

Cover letter [Qemu-devel] [PATCH v12 0/5] remove icc bus/bridge

ICC Bus was used for providing a hotpluggable bus for APIC and CPU, but now we use HotplugHandler to make hotplug. So ICC Bus is unnecessary.

This code has passed the new pc-cpu-test.
And I have tested with kvm along with kernel_irqchip=on/off, it works fine.

This patch series is based on the latest master.

v12:
-move APIC MMIO mapping into x86_cpu_apic_realize() -change commit message in PATCH 4

v11:
-improve commit messages
-split per CPU AS change into a separate patch

v10:
-improve commit messages in patch 1 and 2
-make the check of cpu->cpu_as_root simplier

v9:
-use a callback to correct reset sequence for x86 -update apic mmio mapping

Chen Fan (2):
apic: move APIC's MMIO region mapping into APIC
cpu/apic: drop icc bus/bridge

Zhu Guihua (3):
apic: use per CPU AS to map APIC MMIO for TCG
x86: use new method to correct reset sequence
icc_bus: drop the unused files

 default-configs/i386-softmmu.mak   |   1 -
 default-configs/x86_64-softmmu.mak |   1 -
 hw/cpu/Makefile.objs               |   1 -
 hw/cpu/icc_bus.c                   | 118 -------------------------------------
 hw/i386/pc.c                       |  46 ++++++++-------
 hw/i386/pc_piix.c                  |   9 +--
 hw/i386/pc_q35.c                   |   9 +--
 hw/intc/apic_common.c              |  11 +---
 include/hw/cpu/icc_bus.h           |  82 --------------------------
 include/hw/i386/apic_internal.h    |   7 ++-
 include/hw/i386/pc.h               |   2 +-
 target-i386/cpu.c                  |  33 ++++++++---
 12 files changed, 58 insertions(+), 262 deletions(-)
 delete mode 100644 hw/cpu/icc_bus.c
 delete mode 100644 include/hw/cpu/icc_bus.h
Signature · 1 line
1.9.3