Skip to content

trace-cmd: Improve multi-instance support

Howard Cochran lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest5 patches 0 repliesNew

Changes in v3 from the cover letter

* Improved clarification of options in documentation of trace-cmd reset and added examples.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5trace-cmd extract: Add -B and -t for multiple instancestrace-record.c trace-usage.c+17 -90 replies
2/5trace-cmd extract: Add -a option for all instancesDocumentation/trace-cmd-extract.1.txt trace-local.h trace-record.c +1 more+98 -60 replies
3/5trace-cmd stop, reset, restart: Add -a for all instancesDocumentation/trace-cmd-reset.1.txt Documentation/trace-cmd-stop.1.txt trace-record.c +1 more+119 -290 replies
4/5trace-cmd snapshot: Fully support multiple instancesDocumentation/trace-cmd-snapshot.1.txt trace-cmd.c trace-local.h +3 more+75 -490 replies
5/5trace-cmd stat: Support -a for all buffers. Update docs.Documentation/trace-cmd-stat.1.txt trace-stat.c trace-usage.c+35 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] trace-cmd: Improve multi-instance support

NOTE: The previous two versions of this patch set were distributed off-list.

v3 changes:
* Improved clarification of options in documentation of trace-cmd reset and added examples.

v2 changes:
* Rebased this patch series on Steve's simplification of first_instance logic.

Improve the completeness and consistency of support for multiple buffer instances in the extract, snapshot, stat, start, stop, reset, and restart sub-commands.

For the commands that lacked it, added support for -B and -t options, consistent with the existing behavior of stop, reset, and restart. That is, including a -B instance-name option will cause these commands to exclude the top buffer instance unless -t is also provided.

Exception: trace-cmd start retains its existing behavior regarding the top instance, consistent with trace-cmd record.

For all of these sub-commands except start, add a new -a option, which causes it to operate on all existing instances. As with -B, -a will exclude the top instance unless -t is also given.

Updated documentation accordingly.

Howard Cochran (5):
trace-cmd extract: Add -B and -t for multiple instances trace-cmd extract: Add -a option for all instances trace-cmd stop, reset, restart: Add -a for all instances trace-cmd snapshot: Fully support multiple instances trace-cmd stat: Support -a for all buffers. Update docs.

 Documentation/trace-cmd-extract.1.txt  |  16 ++++
 Documentation/trace-cmd-reset.1.txt    |  57 ++++++++++--
 Documentation/trace-cmd-snapshot.1.txt |  16 +++-
 Documentation/trace-cmd-stat.1.txt     |  19 ++++
 Documentation/trace-cmd-stop.1.txt     |  13 ++-
 trace-cmd.c                            |   2 +-
 trace-local.h                          |   6 +-
 trace-record.c                         | 160 ++++++++++++++++++++++++++++-----
 trace-snapshot.c                       |  90 ++++++++++---------
 trace-stat.c                           |  15 +++-
 trace-usage.c                          |  42 ++++++---
 11 files changed, 341 insertions(+), 95 deletions(-)
Signature · 1 line
1.9.1