Better transaction abort reports
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | btrfs: report exact callsite where transaction abort occursfs/ fs/ | +9 | 0 replies | |
| 2/3 | btrfs: add 'cold' compiler annotations to all error handling functionsfs/ fs/ | +7 | 0 replies | |
| 3/3 | btrfs: fix warnings after changes in btrfs_abort_transactionfs/ fs/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] Better transaction abort reports
Hi,
patch #1 moves the WARN at transaction abort time to the callsite (via macro). That way we get the exact location of the error and not the common location. This is supposed to help debugging and screening report, but the change comes at some cost and increases the resulting asm code.
I vote for better error reports, the .text grows all the time anyway. Patch #2 adds some compiler hints so the error blocks are likely to be put out of the hot paths.
Available in
git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git dev/abort-onsite
David Sterba (3):
btrfs: report exact callsite where transaction abort occurs
btrfs: add 'cold' compiler annotations to all error handling functions
btrfs: fix warnings after changes in btrfs_abort_transaction
fs/btrfs/ctree.h | 16 +++++++++++++--- fs/btrfs/ioctl.c | 2 +- fs/btrfs/super.c | 11 +++-------- fs/btrfs/volumes.c | 6 +++--- 4 files changed, 20 insertions(+), 15 deletions(-)
Signature · 1 line
2.1.3